[device/dx010] configuration port index start from 1 #1927

pphuchar · 2018-08-14T10:58:54Z

- What I did
Update following SKU's port index to start from 1.

Seastone-DX010-10-50
Seastone-DX010-50
Seastone-DX010

- How I did it

Update SKU's port_config.ini
Update sfputil.py plugin

- How to verify it
Run sfputil ... to verify all function work properly.

- Description for the changelog

Device Dx010 update port index start from 1.

Port index in port_config.ini now start from 1. * Seastone-DX010-10-50 port config update * Seastone-DX010-50 port config update * Seastone-DX010 port config update

* Implement lpmode set function. * Implement transceiver reset function. * Python code style format.

*New line cause parsing error in sfputilbase.

*This needed by new sfputilbase implement.

yxieca · 2018-08-14T14:36:38Z

device/celestica/x86_64-cel_seastone-r0/plugins/sfputil.py

@@ -41,7 +41,8 @@ def __init__(self):

        for x in range(self.PORT_START, self.PORT_END + 1):
            if self.port_start == 1:
-                self.port_to_eeprom_mapping[x] = eeprom_path.format((x - 1) + 26)
+                self.port_to_eeprom_mapping[
+                    x] = eeprom_path.format((x - 1) + 26)


This line break looks like an accident to me. Can you fix it?

Fixed in 5db2123

yxieca · 2018-08-14T14:38:52Z

device/celestica/x86_64-cel_seastone-r0/plugins/sfputil.py

@@ -83,7 +84,8 @@ def get_low_power_mode(self, port_num):
            return False

        try:
-            reg_file = open("/sys/devices/platform/dx010_cpld/qsfp_lpmode", "r")
+            reg_file = open(
+                "/sys/devices/platform/dx010_cpld/qsfp_lpmode", "r")


Can you remove above link break?

Fixed in 5db2123

yxieca · 2018-08-14T14:39:22Z

device/celestica/x86_64-cel_seastone-r0/plugins/sfputil.py

+
+        try:
+            reg_file = open(
+                "/sys/devices/platform/dx010_cpld/qsfp_lpmode", "r+")


Please merge above 2 lines into one.

Fixed in 5db2123

yxieca · 2018-08-14T14:39:54Z

device/celestica/x86_64-cel_seastone-r0/plugins/sfputil.py

+
+        try:
+            reg_file = open(
+                "/sys/devices/platform/dx010_cpld/qsfp_reset", "r+")


Please merge above 2 lines into one.

Fixed in 5db2123

yxieca

There are a few extra line breaks that should be removed. Otherwise looks good to me.

zhenggen-xu

Can you justify why we want to have index from 1 instead of 0? What is broken today?

pphuchar · 2018-08-15T04:36:30Z

@zhenggen-xu This index change is requested by @yxieca.
The front panel port index of dx010 is started from 1.

lguohan · 2018-08-15T13:04:39Z

@zhenggen-xu , nothing is broken. is it refactoring the sfp plugin code and make index align with other platforms, starting from 1. If you do not extra dependency on this index, there should be no concern.

* update sfputil, port indext start from 1 * DX010 update SKUs port config index Port index in port_config.ini now start from 1. * Seastone-DX010-10-50 port config update * Seastone-DX010-50 port config update * Seastone-DX010 port config update * Update dx010 sfputil plugin * Implement lpmode set function. * Implement transceiver reset function. * Python code style format. * Remove new line at the end of port_config.ini *New line cause parsing error in sfputilbase. * Add get_transceiver_change_event method *This needed by new sfputilbase implement. * Fix unintended line breaks

3fa0854 [CLI][show bgp] On chassis don't show internal BGP sessions by default (sonic-net#1927) 6de91af [Auto-Techsupport] Issues related to Multiple Cores crashing handled (sonic-net#1948) 656ade1 SFP-Refactor: Vendor revision is not displayed properly (sonic-net#1950) 67466cb [port] Fix port speed set (sonic-net#1952) 5172972 Fix invalid output of syslog IPv6 servers (sonic-net#1933) 290ff5f Routed subinterface enhancements (sonic-net#1821) 1ea88e2 Enhance sfputil for CMIS QSFP (sonic-net#1949) Signed-off-by: Vivek Reddy Karri <[email protected]>

f81043b1f9ff02196629655f4735b33afd7f0ae1 (HEAD -> 202111, origin/202111) [port2alias]: Fix to get right number of return values (#1906) bbbf65943ec46e9330eadaed8bcdf1612cb8bd55 [CLI][show bgp] On chassis don't show internal BGP sessions by default (#1927) e12de7e7bf6cff3ec127f261bf88e4d29776d27b [port] Fix port speed set (#1952) cae7af752d484956d7fe40e4c3a849ddad460976 Fix invalid output of syslog IPv6 servers (#1933) 6009341ddf790094166be5f0a81b4c114f00220b Routed subinterface enhancements (#1821) 6ab9d67ca6550c592b97afb513804be474f84eb0 Enhance sfputil for CMIS QSFP (#1949) 76cc67ba4f81c69b20efb3341808037c9db8f703 [debug dump] Refactoring Modules and Unit Tests (#1943) cff58a8171423e4012bc8caf9748996a1e98b7e2 Add command reference for trap flow counters (#1876) 71cf3ee43524d56ad57dd90b937cfbf4bf63ba6a [Reclaim buffer] [Mellanox] Db migrator support reclaiming reserved buffer for unused ports (#1822) e699b49fb722e6d6fe5a1d2dacd2d39eb085c1e4 Add show command for BFD sessions (#1942) bb6c5774c843dbfad5f1ba00ee76dae7720902d1 [warm-reboot] Fix failures of warm reboot on disconnect of ssh session (#1529) 2e8bbb308477862a76d2327fcf696875e8f08650 Add trap flow counter support (#1868) 58407c1386ef13772a9a9320a795e380f162ab2c [load_minigraph] Delay pfcwd start until the buffer templates are rendered (#1937) eb388e0584ba1fe8d8dba58f1c5a148036ffe047 [sonic-package-manager] support sonic-cli-gen and packages with YANG model (#1650) 2371d84e7d281bdb9988b5a1a012498dbbfb89ec generic_config_updater: Filename changed & VLAN validator added (#1919) 7c0718dfaf23289d4ecc3ada9332e465c9a4e56b [config reload] Update command reference (#1941) Signed-off-by: Abhishek Dosi <[email protected]>

#### Why I did it Including below commits: ``` fe00bbf 2021-12-17 | Revert "[sonic-package-manager] support sonic-cli-gen and packages with YANG model (#1650)" (#1972) [Prince George] 5fe6d92 2021-12-16 | [warm/fast-reboot] Fix kexec portion to support platforms based on Device Tree (#1966) [dflynn-Nokia] 74d2a09 2021-12-17 | [portstat] check TX/RX utilization calculation correctness (#1840) [Andriy Yurkiv] e44c3f6 2021-12-16 | [generic-config-updater] Improving CreateOnly validator and marking /LOOPBACK_INTERFACE/LOOPBACK#/vrf_name as create-only (#1969) [Mohamed Ghoneim] 0067cc4 2021-12-15 | [build] adapt for upstream target path change (#1971) [Qi Luo] 96143ee 2021-12-09 | preserve old order for config reload (#1964) [arlakshm] f08c81d 2021-12-10 | [vxlan] remove unnecessary whitespace for show commands (#1792) [Gord Chen] 14889ce 2021-12-09 | [soft-reboot] Add support for platforms based on Device Tree (#1963) [dflynn-Nokia] 7ceccd7 2021-12-08 | [generic-config-updater] Adding non-strict mode (#1929) [Mohamed Ghoneim] 2e462ef 2021-12-07 | [sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947) [Prince George] 7c34b79 2021-12-07 | [config] Add portchannel support for static route (#1857) [Dmytro] 54cc370 2021-12-06 | [doc] Refine doc on show loopback/mgmt ports (#1958) [Qi Luo] 3714f63 2021-12-06 | [port2alias]: Fix to get right number of return values (#1906) [SuvarnaMeenakshi] 3fa0854 2021-12-06 | [CLI][show bgp] On chassis don't show internal BGP sessions by default (#1927) [Mahesh Maddikayala] 6de91af 2021-12-06 | [Auto-Techsupport] Issues related to Multiple Cores crashing handled (#1948) [Vivek Reddy] 656ade1 2021-12-06 | SFP-Refactor: Vendor revision is not displayed properly (#1950) [Aravind Mani] 67466cb 2021-12-05 | [port] Fix port speed set (#1952) [Mykola Gerasymenko] 5172972 2021-12-04 | Fix invalid output of syslog IPv6 servers (#1933) [jingwenxie] 290ff5f 2021-12-03 | Routed subinterface enhancements (#1821) [Preetham] 1ea88e2 2021-12-01 | Enhance sfputil for CMIS QSFP (#1949) [andywongarista] 4e132c1 2021-11-30 | [debug dump] Refactoring Modules and Unit Tests (#1943) [Vivek Reddy] b550c44 2021-11-30 | Add command reference for trap flow counters (#1876) [Junchao-Mellanox] 67a267b 2021-11-30 | [Reclaim buffer] [Mellanox] Db migrator support reclaiming reserved buffer for unused ports (#1822) [Stephen Sun] 30e4654 2021-11-25 | Add show command for BFD sessions (#1942) [Shi Su] e63f47e 2021-11-25 | [warm-reboot] Fix failures of warm reboot on disconnect of ssh session (#1529) [maksymbelei95] c05845d 2021-11-25 | Add trap flow counter support (#1868) [Junchao-Mellanox] ef82f00 2021-11-24 | [load_minigraph] Delay pfcwd start until the buffer templates are rendered (#1937) [Neetha John] f5e5a56 2021-11-24 | [sonic-package-manager] support sonic-cli-gen and packages with YANG model (#1650) [Stepan Blyshchak] 64777a4 2021-11-23 | generic_config_updater: Filename changed & VLAN validator added (#1919) [Renuka Manavalan] 1f8f6ab 2021-11-23 | [config reload] Update command reference (#1941) [Sudharsan Dhamal Gopalarathnam] ```

sonic-net#1927)

pphuchar added 5 commits August 10, 2018 15:58

update sfputil, port indext start from 1

5bf5985

DX010 update SKUs port config index

f77edc7

Port index in port_config.ini now start from 1. * Seastone-DX010-10-50 port config update * Seastone-DX010-50 port config update * Seastone-DX010 port config update

Update dx010 sfputil plugin

8f165e5

* Implement lpmode set function. * Implement transceiver reset function. * Python code style format.

Remove new line at the end of port_config.ini

6c4e282

*New line cause parsing error in sfputilbase.

Add get_transceiver_change_event method

79838d5

*This needed by new sfputilbase implement.

yxieca reviewed Aug 14, 2018

View reviewed changes

zhenggen-xu suggested changes Aug 14, 2018

View reviewed changes

Fix unintended line breaks

5db2123

stcheng added the Bug 🐛 label Aug 15, 2018

lguohan added Enhancement ➕ and removed Bug 🐛 labels Aug 15, 2018

yxieca approved these changes Aug 16, 2018

View reviewed changes

sonic-net deleted a comment from lguohan Aug 16, 2018

zhenggen-xu approved these changes Aug 16, 2018

View reviewed changes

yxieca merged commit fd5bce5 into sonic-net:master Aug 16, 2018

stcheng added the Platform: Celestica label Aug 21, 2018

pphuchar deleted the device-dx010-update-sfputil branch August 28, 2018 08:59

taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022

[CLI][show bgp] On chassis don't show internal BGP sessions by default (

3fa0854

sonic-net#1927)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[device/dx010] configuration port index start from 1 #1927

[device/dx010] configuration port index start from 1 #1927

pphuchar commented Aug 14, 2018

yxieca Aug 14, 2018

pphuchar Aug 15, 2018

yxieca Aug 14, 2018

pphuchar Aug 15, 2018

yxieca Aug 14, 2018

pphuchar Aug 15, 2018

yxieca Aug 14, 2018

pphuchar Aug 15, 2018

yxieca left a comment

zhenggen-xu left a comment

pphuchar commented Aug 15, 2018

lguohan commented Aug 15, 2018

[device/dx010] configuration port index start from 1 #1927

[device/dx010] configuration port index start from 1 #1927

Conversation

pphuchar commented Aug 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yxieca left a comment

Choose a reason for hiding this comment

zhenggen-xu left a comment

Choose a reason for hiding this comment

pphuchar commented Aug 15, 2018

lguohan commented Aug 15, 2018