Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Yang Support for attribute slice_type to DEVICE_METADATA #19094

Merged
merged 16 commits into from
May 31, 2024

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented May 28, 2024

What I did:
Added Yang model support for new attribute in DEVICE_METADATA of slice_type

Why I did:

For Spine Router we use this metadata to run-time decide the BGP template to use.

How I verify:

  • Manual Verification
  • UT added

@abdosi abdosi requested a review from qiluo-msft as a code owner May 28, 2024 01:24
@abdosi abdosi requested a review from arlakshm May 28, 2024 01:24
@gechiang gechiang added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label May 28, 2024
@abdosi abdosi changed the title Added Support to Parse Associated Slice in minigraph and add as config to DEVICE_METADATA Added Yang Support for attribute slice_type to DEVICE_METADATA May 31, 2024
@arlakshm arlakshm added the YANG YANG model related changes label May 31, 2024
@rlhui rlhui merged commit d912366 into sonic-net:master May 31, 2024
20 checks passed
lguohan pushed a commit that referenced this pull request Jun 6, 2024
…minigraph (#19160)

What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type.
Yang model are done as part of : #19094

Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.

Why I did:
In BGP Templates we need to take different action based on this attribute.

Signed-off-by: Abhishek Dosi <[email protected]>
@abdosi abdosi removed the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label Jun 6, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 12, 2024
…minigraph (sonic-net#19160)

What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type.
Yang model are done as part of : sonic-net#19094

Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.

Why I did:
In BGP Templates we need to take different action based on this attribute.

Signed-off-by: Abhishek Dosi <[email protected]>
mssonicbld pushed a commit that referenced this pull request Jun 15, 2024
…minigraph (#19160)

What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type.
Yang model are done as part of : #19094

Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.

Why I did:
In BGP Templates we need to take different action based on this attribute.

Signed-off-by: Abhishek Dosi <[email protected]>
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
…c-net#19094)

*Added Yang model support for new attribute in DEVICE_METADATA of slice_type

---------

Signed-off-by: Abhishek Dosi <[email protected]>
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
…minigraph (sonic-net#19160)

What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type.
Yang model are done as part of : sonic-net#19094

Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.

Why I did:
In BGP Templates we need to take different action based on this attribute.

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
YANG YANG model related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants