-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Yang Support for attribute slice_type to DEVICE_METADATA #19094
Merged
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c5ed3a.
This reverts commit 109e194.
Signed-off-by: Abhishek Dosi <[email protected]>
This reverts commit 6545569.
Signed-off-by: Abhishek Dosi <[email protected]>
This reverts commit b80b20e.
to DEVICE_METADATA. Yang model updated accordingly. Signed-off-by: Abhishek Dosi <[email protected]>
gechiang
added
the
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
label
May 28, 2024
…as config" This reverts commit 789c97c.
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
changed the title
Added Support to Parse Associated Slice in minigraph and add as config to DEVICE_METADATA
Added Yang Support for attribute slice_type to DEVICE_METADATA
May 31, 2024
arlakshm
approved these changes
May 31, 2024
lguohan
pushed a commit
that referenced
this pull request
Jun 6, 2024
…minigraph (#19160) What I did: Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type. Yang model are done as part of : #19094 Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct. Why I did: In BGP Templates we need to take different action based on this attribute. Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
removed
the
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
label
Jun 6, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 12, 2024
…minigraph (sonic-net#19160) What I did: Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type. Yang model are done as part of : sonic-net#19094 Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct. Why I did: In BGP Templates we need to take different action based on this attribute. Signed-off-by: Abhishek Dosi <[email protected]>
mssonicbld
pushed a commit
that referenced
this pull request
Jun 15, 2024
…minigraph (#19160) What I did: Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type. Yang model are done as part of : #19094 Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct. Why I did: In BGP Templates we need to take different action based on this attribute. Signed-off-by: Abhishek Dosi <[email protected]>
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…c-net#19094) *Added Yang model support for new attribute in DEVICE_METADATA of slice_type --------- Signed-off-by: Abhishek Dosi <[email protected]>
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…minigraph (sonic-net#19160) What I did: Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type. Yang model are done as part of : sonic-net#19094 Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct. Why I did: In BGP Templates we need to take different action based on this attribute. Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added Yang model support for new attribute in
DEVICE_METADATA
ofslice_type
Why I did:
For Spine Router we use this metadata to run-time decide the BGP template to use.
How I verify: