[YANG] Add valid v6 address to sonic-dhcp-sever.yang #18690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Apr 20, 2024
| @@ -7,7 +7,7 @@ | |||
| }, | |||
| "DHCP_SERVER": { | |||
| "192.0.0.8": {}, | |||
| "192.0.0.8": {} | |||
There was a problem hiding this comment.
Do not delete old test data. I believe it is intentionally duplicating above item, and it is a corner case to test. #Closed
There was a problem hiding this comment.
This is added in sonic-dhcp_server.yang PR: #12175
It should not be related to corner case since the build has passed.
Blueve
approved these changes
Apr 23, 2024
qiluo-msft
approved these changes
Apr 23, 2024
yaqiangz
approved these changes
Apr 25, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 9, 2024
#### Why I did it The PR is to allow v6 address in DHCP_SERVER table which was generated from PROD minigraph. This is to pass the YANG validation. #### How I did it Replace ipv4-address with ip-address which is a union of ipv4-address nad ipv6-address #### How to verify it Unit test
|
Cherry-pick PR to 202305: #18920 |
mssonicbld
pushed a commit
that referenced
this pull request
May 11, 2024
#### Why I did it The PR is to allow v6 address in DHCP_SERVER table which was generated from PROD minigraph. This is to pass the YANG validation. #### How I did it Replace ipv4-address with ip-address which is a union of ipv4-address nad ipv6-address #### How to verify it Unit test
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
|
@yxieca could you please help to approve this backport to 202311? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 15, 2024
#### Why I did it The PR is to allow v6 address in DHCP_SERVER table which was generated from PROD minigraph. This is to pass the YANG validation. #### How I did it Replace ipv4-address with ip-address which is a union of ipv4-address nad ipv6-address #### How to verify it Unit test
|
Cherry-pick PR to 202311: #18974 |
mssonicbld
pushed a commit
that referenced
this pull request
May 15, 2024
#### Why I did it The PR is to allow v6 address in DHCP_SERVER table which was generated from PROD minigraph. This is to pass the YANG validation. #### How I did it Replace ipv4-address with ip-address which is a union of ipv4-address nad ipv6-address #### How to verify it Unit test
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The PR is to allow v6 address in DHCP_SERVER table which was generated from PROD minigraph. This is to pass the YANG validation.
Work item tracking
How I did it
Replace ipv4-address with ip-address which is a union of ipv4-address nad ipv6-address
How to verify it
Unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)