-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Update backend acl template and unit tests #18659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <[email protected]>
bingwang-ms
approved these changes
Apr 12, 2024
I noticed there are two vlans in some Backend T0 devices. The change may break this scenario.
|
Discussed offline, the behavior is not changed even in two-vlan scenario. In two-vlan scenario, the packets with both vlan_ids are accepted, but it will be dropped on the ports with different VLAN_ID. |
bingwang-ms
approved these changes
Apr 12, 2024
prsunny
approved these changes
Apr 13, 2024
@yxieca , please help merge |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Apr 15, 2024
Signed-off-by: Neetha John <[email protected]>
Cherry-pick PR to 202311: #18685 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Apr 15, 2024
Signed-off-by: Neetha John <[email protected]>
Cherry-pick PR to 202305: #18686 |
mssonicbld
pushed a commit
that referenced
this pull request
Apr 15, 2024
Signed-off-by: Neetha John <[email protected]>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Apr 15, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Apr 15, 2024
Signed-off-by: Neetha John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Backend acl load is failing since IN_PORTS qualifier is no longer supported. Changing the template to match only on vlan since the only the vlan ports are bound to the DATAACL for backend (https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-config-engine/minigraph.py#L1346)
Work item tracking
How to verify it
Unit test to validate the template rendering
Tested on 202305 branch. Acl loaded successfully after this change.
Cannot test on internal branch since the slim image is too big to load on 7050qx and this change is only applicable to 7050qx.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
20230531.24 with the patch