Convert arp_update into a 'start-it-once' mode #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
Jul 16, 2018
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
yxieca
pushed a commit
that referenced
this pull request
Jul 19, 2018
* Run arp_update just once, don't restart it. It will run continuosly with 5 min pauses
5 tasks
wen587
added a commit
that referenced
this pull request
Oct 26, 2021
8ea834b [sonic_installer] Change sonic_installer check ASIC mismatch by platforms list (#1836) 9017d99 Fix the option missing in kernel config issue (#1888) 6595ad4 [mlag] fix log print sequence (#1730) e600e1c CLI command to load config in Yang format (#1781) 00948d0 Fix the target db version of portchannel-key test (#1842) 6412fea [sonic-package-manager] remove make_python_identifier (#1801) f738818 [sonic-package-manager] stop service explicitelly before uninstalling package (#1805) d8ee5e9 Remove exec from platform_reboot_plugin call to handle any hang issue. (#1879) 827fcee [chassis][routecheck]filter out the chassis internal interfaces (#1798) 4d732c6 [generic_config_updater] Logging (#1864) 25bb184 [config]: Add loopback interfaces to interface name checker (#1869) c950a55 Validate input of config mirror_session add (#1825) 9ab20fd [show][config] fix the muxcable commands for interface naming mode (#1862) 476b3a4 [multi-asic][cli][chassis-db] Avoid connecting to chassis db for cli commands executed from linecard (#1707)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
New changes in sairedis repo will move zmq dependency to libsaimeta
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
#### What I did
Add some logs to generic_updater
#### How I did it
#### How to verify it
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)
Empty patch
```
admin@vlab-01:~$ sudo config apply-patch empty.json-patch
Patch Applier: Patch application starting.
Patch Applier: Patch: []
Patch Applier: Validating patch is not making changes to tables without YANG models.
Patch Applier: Getting current config db.
Patch Applier: Simulating the target full config after applying the patch.
Patch Applier: Validating target config according to YANG models.
... [logs from sonic-yang-mgmt framework]
Patch Applier: Sorting patch updates.
Patch Applier: The patch was sorted into 0 changes.
Patch Applier: Applying changes in order.
Patch Applier: Verifying patch updates are reflected on ConfigDB.
Patch Applier: Patch application completed.
Patch applied successfully.
admin@vlab-01:~$
```
Single change patch
```
admin@vlab-01:~$ sudo config apply-patch dhcp_add.json-patch
Patch Applier: Patch application starting.
Patch Applier: Patch: [{"op": "add", "path": "/VLAN/Vlan1000/dhcp_servers/4", "value": "192.0.0.5"}]
Patch Applier: Validating patch is not making changes to tables without YANG models.
Patch Applier: Getting current config db.
Patch Applier: Simulating the target full config after applying the patch.
Patch Applier: Validating target config according to YANG models.
... [logs from sonic-yang-mgmt framework]
Patch Applier: The patch was sorted into 1 change:
Patch Applier: * [{"op": "add", "path": "/VLAN/Vlan1000/dhcp_servers/4", "value": "192.0.0.5"}]
Patch Applier: Applying changes in order.
Failed to apply patch
Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH
Try "config apply-patch -h" for help.
Error: ChangeApplier.apply(change) is not implemented yet
admin@vlab-01:~$
```
Multi change patch:
```
admin@vlab-01:~$ sudo config apply-patch update_lanes.json-patch
Patch Applier: Patch application starting.
Patch Applier: Patch: [{"op": "replace", "path": "/PORT/Ethernet100/lanes", "value": "121,122,123"}]
Patch Applier: Validating patch is not making changes to tables without YANG models.
Patch Applier: Getting current config db.
Patch Applier: Simulating the target full config after applying the patch.
Patch Applier: Validating target config according to YANG models.
... [logs from sonic-yang-mgmt framework]
Patch Applier: Sorting patch updates.
... [logs from sonic-yang-mgmt framework]
Patch Applier: The patch was sorted into 2 changes:
Patch Applier: * [{"op": "remove", "path": "/PORT/Ethernet100"}]
Patch Applier: * [{"op": "add", "path": "/PORT/Ethernet100", "value": {"alias": "fortyGigE0/100", "description": "fortyGigE0/100", "index": "25", "lanes": "121,122,123", "mtu": "9100", "pfc_asym": "off", "speed": "40000", "tpid": "0x8100"}}]
Patch Applier: Applying changes in order.
Failed to apply patch
Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH
Try "config apply-patch -h" for help.
Error: ChangeApplier.apply(change) is not implemented yet
admin@vlab-01:~$
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I converted arp_update to 'start-it-once' mode. It'll allow us to reduce amount of supervisord log messages.
- How I did it
Add infinite external loop inside of arp_update
- How to verify it
Build an image and run on a DUT
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)