Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make] introducing new build option KERNEL_PROCURE_METHOD #1837

Merged
merged 3 commits into from
Jul 25, 2018
Merged

[make] introducing new build option KERNEL_PROCURE_METHOD #1837

merged 3 commits into from
Jul 25, 2018

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Jul 2, 2018 •
edited
Loading

Note: this PR is best go in before sonic-net/sonic-linux-kernel#51.

Signed-off-by: Ying Xie [email protected]

- What I did
Introducing the option of downloading pre-built kernel instead of building it every time.

  • Kernel could be built from source files with method 'build'
  • Kernel could be downloaded from Azure storage with method 'download'

- How to verify it

  1. The kernel being downloaded was built with make KERNEL_PROCURE_METHOD=build
  2. Tried to build image with option "KERNEL_PROCURE_METHOD=download" as well.

@yxieca
[make] introducing new build option KERNEL_BUILD_METHOD
da51a70 
- Kernel could be built from source files with method 'build'
- Kernel could be downloaded from Azure storage with method 'download'

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca mentioned this pull request Jul 2, 2018
Merged
@yxieca yxieca requested a review from lguohan July 2, 2018 20:15
jleveque
jleveque reviewed Jul 2, 2018
View reviewed changes
Makefile Outdated
@@ -15,7 +15,8 @@
# * PASSWORD: Desired password -- default at rules/config
# * KEEP_SLAVE_ON: Keeps slave container up after building-process concludes.
# * SOURCE_FOLDER: host path to be mount as /var/$(USER)/src, only effective when KEEP_SLAVE_ON=yes
# * SONIC_BUILD_JOB: Specifying number of concurrent build job(s) to run
# * SONIC_BUILD_JOBS: Specifying number of concurrent build job(s) to run
# * KERNEL_BUILD_METHOD: Specifying method of building kernel: download or build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same small concern I raised on the linked PR in sonic-linux-kernel: The terminology might not be intuitive (i.e., that one of the "build methods" is "download" which doesn't actually build anything). I think a name like "KERNEL_PROCURE_METHOD" is more accurate. Maybe someone else has another suggestion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROCURE sounds good to me.

jleveque
jleveque suggested changes Jul 2, 2018
View reviewed changes
rules/config Outdated

# DEFAULT_KERNEL_BUILD_METHOD - default method for building kernel
# build: build kernel from source
# download: downlaod built kernel from Azure storage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "downlaod"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also suggest changing "built" to "prebuilt".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done.

jleveque
jleveque approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update title and description to reference new variable name.

@yxieca yxieca changed the title [make] introducing new build option KERNEL_BUILD_METHOD [make] introducing new build option KERNEL_PROCURE_METHOD Jul 2, 2018
@yxieca yxieca merged commit 3c33737 into sonic-net:master Jul 25, 2018
@Junchao-Mellanox Junchao-Mellanox mentioned this pull request Sep 24, 2021
Merged
5 tasks
qiluo-msft pushed a commit that referenced this pull request Sep 28, 2021
@Junchao-Mellanox
[submodule] Update submodule for sonic-utilities (#8752)
c770375 
0d538d3 [ci]: Support code diff coverage (#1834)
48887d1 [config] support for configuring muxcable to standby mode of operation (#1837)
2088a9a Provide support to install platform extensions (#1578)
c97fe54 Add check_db_integrity script to setup.py (#1828)
c0b9917 [debug dump util] COPP Module Added (#1670)
826311c [techsupport] Removed interactive option for docker commands and Improved Error Reporting (#1723)
ce11545 [config reload] Removed job-mode for sonic.target restart (#1820)
f76f672 [fdbshow]: Fix typo in comment (#1809)
17208a0 [ci]: Support PR coverage (#1806)
c2c2354 fix wrong code indent in sfputil (#1808)
47a9a0f [portconfig] Validate duplicate speed value and interface type value (#1745)
f1086ee [sonic_installer]Add --skip-platform-check option for sonic_installer when image mismatch (#1791)
c007d65 [warm-reboot] Add new preboot health check: verify database integrity (#1785)
41e31e8 Fix PatchApplier init order (#1762)
2416175 [config reload] Fix config reload failure due to sonic.target job cancellation (#1814)
2b12aad [portstat, intfstat] added rates and utilization (#1750)
26e700a [debug dump util] Techsupport addition (#1669)
9f2326e [debug dump util] Base Skeleton and Click Class added (#1668)
vdahiya12 added a commit to vdahiya12/sonic-buildimage that referenced this pull request Sep 29, 2021
@vdahiya12
[sonic-utilities] submodule update
ab0c9d2 
0b5f90b (HEAD -> 202012, origin/202012) [show techsupport] fix bash errors in generate_dump script (sonic-net#1844)
388c50c [202012][warmboot] Add new preboot health check: verify db integrity (sonic-net#1839)
d73dc98 [config] support for configuring muxcable to standby mode of operation (sonic-net#1837)

Signed-off-by: vaibhav-dahiya <[email protected]>
@vdahiya12 vdahiya12 mentioned this pull request Sep 29, 2021
Merged
5 tasks
lguohan pushed a commit that referenced this pull request Sep 30, 2021
@vdahiya12
[sonic-utilities] submodule update (#8865)
90cfc08 
0b5f90b (HEAD -> 202012, origin/202012) [show techsupport] fix bash errors in generate_dump script (#1844)
388c50c [202012][warmboot] Add new preboot health check: verify db integrity (#1839)
d73dc98 [config] support for configuring muxcable to standby mode of operation (#1837)

Signed-off-by: vaibhav-dahiya <[email protected]>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@stephenxs
[Reclaiming buffer] Support reclaiming buffer in traditional model (s…
4f6cb05 
…onic-net#2011)

- What I did
It's to port sonic-net#1837 to master to reclaim reserved buffer.
As the way to do it differs among vendors, buffermgrd will:
1. Handle port admin down on Mellanox platform.
    - Not apply lossless buffer PG to an admin-down port
    - Remove lossless buffer PG (3-4) from a port when it is shut down.
2. Read lossless buffer PG (3-4) to a port when a port is started up.

- Why I did it
To support reclaiming reserved buffer when a port is shut down on Mellanox platform in traditional buffer model.

- How I verified it
sonic-mgmt test and vs test.

Signed-off-by: Stephen Sun <[email protected]>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@vdahiya12
[config] support for configuring muxcable to standby mode of operation (
48887d1 
sonic-net#1837)

What I did
This PR adds support for an option to configure muxcable mode to a standby mode. The standby mode is in addition
to auto\active\manual mode.

The new output would look like this in case an standby arg is passed to the command line

admin@sonic:~$ sudo config muxcable mode standby Ethernet0

admin@sonic:~$ sudo config muxcable mode standby all

added an option to set muxcable mode to standby mode, in addition to existing auto/active/manual modes.

How I did it
added the changes in config/muxcable.py and added testcases

How to verify it
Ran the unit tests
Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yxieca @jleveque