[Mellanox] Update Nvidia sai.profile SKU files to have common file #18074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazariig
approved these changes
Feb 8, 2024
|
DEPENDS: sonic-net/sonic-sairedis#1352 |
liat-grozovik
changed the title
dprital
reviewed
Feb 8, 2024
| @@ -0,0 +1,3 @@ | |||
| SAI_DUMP_STORE_PATH=/var/log/mellanox/sdk-dumps | |||
| SAI_DUMP_STORE_AMOUNT=10 | |||
| SAI_DUMP_MFT_CFG_PATH=/etc/mft/fwtrace_cfg | |||
There was a problem hiding this comment.
@noaOrMlnx , I see two kind of paths. One is the one in the default profile and the other appear on several SKUs with the path of:
SAI_DUMP_MFT_CFG_PATH=/etc/sonic/mft/fwtrace_cfg
Please check if this is a mistake and all should point to the same path
dprital
reviewed
Feb 8, 2024
noaOrMlnx
force-pushed
the
sai_profile_enhancements
branch
from
a6806af
to
58228ed
Compare
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
approved these changes
Feb 26, 2024
kcudnik
approved these changes
Feb 26, 2024
11 tasks
|
@yxieca , @qiluo-msft , Can you please merge ? |
liat-grozovik
approved these changes
Feb 28, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 28, 2024
…onic-net#18074) * Update Nvidia sai.profile SKU files to have common file * Remove SAI_DUMP_MFT_CFG_PATH from sai-common.profile as it is not in use
|
Cherry-pick PR to 202311: #18213 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 29, 2024
…18074) * Update Nvidia sai.profile SKU files to have common file * Remove SAI_DUMP_MFT_CFG_PATH from sai-common.profile as it is not in use
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
…onic-net#18074) * Update Nvidia sai.profile SKU files to have common file * Remove SAI_DUMP_MFT_CFG_PATH from sai-common.profile as it is not in use
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
…onic-net#18074) * Update Nvidia sai.profile SKU files to have common file * Remove SAI_DUMP_MFT_CFG_PATH from sai-common.profile as it is not in use
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Mar 13, 2024
### What I did Handle the SAI key value pair if it is present in sai common profile rather than specific profile for mellanox platforms. The concept of common sai profile is introduced in sonic-net/sonic-buildimage#18074 . After this the techsupport started to fail because of the absence of SAI_DUMP_STORE_PATH #### How I did it Check if the variable is not present in platform specific file and then read the common file. If the common file is not accessible due to syncd being down, fallback to default path which is hardcoded. #### How to verify it Running techsupport and ensuring it exits with code 0
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Mar 21, 2024
…ic-net#3196) ### What I did Handle the SAI key value pair if it is present in sai common profile rather than specific profile for mellanox platforms. The concept of common sai profile is introduced in sonic-net/sonic-buildimage#18074 . After this the techsupport started to fail because of the absence of SAI_DUMP_STORE_PATH #### How I did it Check if the variable is not present in platform specific file and then read the common file. If the common file is not accessible due to syncd being down, fallback to default path which is hardcoded. #### How to verify it Running techsupport and ensuring it exits with code 0
mssonicbld
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Mar 21, 2024
### What I did Handle the SAI key value pair if it is present in sai common profile rather than specific profile for mellanox platforms. The concept of common sai profile is introduced in sonic-net/sonic-buildimage#18074 . After this the techsupport started to fail because of the absence of SAI_DUMP_STORE_PATH #### How I did it Check if the variable is not present in platform specific file and then read the common file. If the common file is not accessible due to syncd being down, fallback to default path which is hardcoded. #### How to verify it Running techsupport and ensuring it exits with code 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on sonic-net/sonic-sairedis#1352
Add new common sai.profile,
Update Nvidia/Mellanox sai.profile of all SKUs to remove common parameters.
Why I did it
To have the ability to add common parameters to only 1 file instead of all SKUs.
Work item tracking
How I did it
Add a new common file with all common key-value parameters.
also, updated syncd_init_common.sh to take common parameters from the new file in sonic-net/sonic-sairedis#1352
How to verify it
Run the script with changed .profile files, and make sure all common parameters exist in final sai.profile.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Add new common sai.profile,
Update Nvidia/Mellanox sai.profile of all SKUs to remove common parameters.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)