[device]: Fix a bug that psuutil cannot access gpio sysfs to get PSU status #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Jun 13, 2018
| try: | ||
| with open(export_file, 'w') as fd: | ||
| fd.write(str(gpio_base+pinnum)) | ||
| except Exception as error: | ||
| logging.error("Unable to export gpio ", pinnum) | ||
| logging.error("Unable to export gpio ", str(gpio_base+pinnum)) | ||
| sys.exit(0) |
There was a problem hiding this comment.
why exit 0 here? the plugin should not do exit
There was a problem hiding this comment.
@lguohan OK I'll remove it
lguohan
reviewed
Jun 13, 2018
| @@ -54,6 +67,7 @@ def read_psu_statuses(self, pinnum): | |||
| retval = fd.read() | |||
| except Exception as error: | |||
| logging.error("Unable to open ", gpio_file, "file !") | |||
| sys.exit(0) | |||
There was a problem hiding this comment.
the plugin should not do exit.
There was a problem hiding this comment.
@lguohan OK I'll remove it
jleveque
suggested changes
Jun 13, 2018
| try: | ||
| with open(export_file, 'w') as fd: | ||
| fd.write(str(gpio_base+pinnum)) | ||
| except Exception as error: | ||
| logging.error("Unable to export gpio ", pinnum) | ||
| logging.error("Unable to export gpio ", str(gpio_base+pinnum)) |
There was a problem hiding this comment.
This is invalid syntax. Please change to
logging.error("Unable to export gpio " + str(gpio_base+pinnum))
There was a problem hiding this comment.
OK, I will change it.
jleveque
approved these changes
Jun 15, 2018
lguohan
reviewed
Jun 16, 2018
| except Exception as error: | ||
| logging.error("Unable to get gpio base") | ||
|
|
||
|
|
||
| def init_psu_gpio(self, pinnum): |
There was a problem hiding this comment.
this init_psu_gpio should move to your driver, we should not do init psu gpio on-the-fly.
There was a problem hiding this comment.
@jleveque, We will update init_psu_gpio after we updated our driver
There was a problem hiding this comment.
@pphuchar Please add this to our platform driver
lguohan
reviewed
Jun 16, 2018
| @@ -53,7 +63,7 @@ def read_psu_statuses(self, pinnum): | |||
| with open(gpio_file, 'r') as fd: | |||
| retval = fd.read() | |||
| except Exception as error: | |||
| logging.error("Unable to open ", gpio_file, "file !") | |||
| logging.error("Unable to open " + gpio_file + "file !") | |||
There was a problem hiding this comment.
we should further raise in the plugin, retval = 'ERR' is not the convention to convene error to the caller.
There was a problem hiding this comment.
OK , I will add raise statement to report the error
lguohan
reviewed
Jun 16, 2018
| @@ -53,7 +63,7 @@ def read_psu_statuses(self, pinnum): | |||
| with open(gpio_file, 'r') as fd: | |||
| retval = fd.read() | |||
| except Exception as error: | |||
There was a problem hiding this comment.
we should not catch general exception here, we should only catch exception we can handle in this case the io or file exception.
There was a problem hiding this comment.
OK, I will change it
jleveque
suggested changes
Jun 16, 2018
lguohan
approved these changes
Jun 21, 2018
jleveque
approved these changes
Jun 21, 2018
lguohan
pushed a commit
that referenced
this pull request
Jun 25, 2018
tiantianlv
pushed a commit
to tiantianlv/sonic-buildimage
that referenced
this pull request
Jul 30, 2018
…get PSU status (sonic-net#1789)" This reverts commit 310c3f9.
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Jul 29, 2021
f54b7d0b [Dynamic Buffer Calc][202012]Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net#1820) ac7f5cff Td2: Reclaim buffer from unused ports (sonic-net#1830) 04105a4b [debugcounterorch] check if counter type is supported before querying (sonic-net#1789) a67d8af6 [202012][portsorch] fix errors when moving port from one lag to another. (sonic-net#1819) Signed-off-by: Stephen Sun <[email protected]>
5 tasks
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-buildimage
that referenced
this pull request
Sep 3, 2021
* d240291 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855) * a71a5d3 [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1761) * 197f427 Fix vs test failure in test_buffer_traditional (sonic-net#1881) * 8471f42 Revert "[debugcounterorch] check if counter type is supported before querying… (sonic-net#1789)" (sonic-net#1884) Signed-off-by: Volodymyr Samotiy <[email protected]>
5 tasks
prsunny
pushed a commit
that referenced
this pull request
Sep 3, 2021
* d240291 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (#1855) * a71a5d3 [acl mirror action] Mirror session ref count fix at acl rule attachment (#1761) * 197f427 Fix vs test failure in test_buffer_traditional (#1881) * 8471f42 Revert "[debugcounterorch] check if counter type is supported before querying… (#1789)" (#1884) Signed-off-by: Volodymyr Samotiy <[email protected]>
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-buildimage
that referenced
this pull request
Sep 13, 2021
* d03ba4f [202012] [portstat, intfstat] added rates and utilization (sonic-net#1812) * 499ad3f [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) * 96d658c [202012][sonic installer] Add swap setup support (sonic-net#1815) * a9c6970 platform pre-check for reboot in 202012 branch (sonic-net#1788) * 0e0478b Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795) * 2d1e00e [ecnconfig] Fix exception seen during display and add unit tests (sonic-net#1784) (sonic-net#1789) Signed-off-by: Volodymyr Samotiy <[email protected]>
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Sep 13, 2021
Signed-off-by: Vivek Reddy Karri <[email protected]> d03ba4fa [202012] [portstat, intfstat] added rates and utilization (sonic-net#1812) 499ad3f4 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) 96d658c2 [202012][sonic installer] Add swap setup support (sonic-net#1815) a9c69702 platform pre-check for reboot in 202012 branch (sonic-net#1788) 0e0478ba Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795) 2d1e00ed [ecnconfig] Fix exception seen during display and add unit tests (sonic-net#1784) (sonic-net#1789)
lguohan
pushed a commit
that referenced
this pull request
Sep 14, 2021
* d03ba4f [202012] [portstat, intfstat] added rates and utilization (#1812) * 499ad3f [config reload] Fix config reload failure due to sonic.target job cancellation (#1814) * 96d658c [202012][sonic installer] Add swap setup support (#1815) * a9c6970 platform pre-check for reboot in 202012 branch (#1788) * 0e0478b Unify the number format in the ourput of portstat and pfcstat in all cases (#1795) * 2d1e00e [ecnconfig] Fix exception seen during display and add unit tests (#1784) (#1789) Signed-off-by: Volodymyr Samotiy <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
sonic-net#1789) * [debugcounterorch] check if counter type is supported before querying object availability count Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix bug that found on #1781
- How I did it
Update code to support dynamic sysfs gpio base.
- How to verify it
In SONiC run psuutil cli to test the following case:
PSU1: Absence
PSU1: Presence, no-power
PSU2: Absence
PSU1: Presence, no-power