-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chassis] update service_checker module to handle database-chassis service #17836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peer device's Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
higher value so that BGP learnt default route is higher priority. Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
added
Request for 202305 Branch
Request for 202311 Branch
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
labels
Jan 18, 2024
judyjoseph
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
THis is needed for alert. |
5 tasks
gechiang
added
the
Included in Chassis for 202205 Branch
Indicate PR is already in MSFT repo 202205 branch
label
Feb 5, 2024
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 16, 2024
…rvice (sonic-net#17836) * Update service_checker.py Signed-off-by: Abhishek Dosi <[email protected]>
Cherry-pick PR to 202311: #18119 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 19, 2024
…rvice (#17836) * Update service_checker.py Signed-off-by: Abhishek Dosi <[email protected]>
rlhui
pushed a commit
that referenced
this pull request
Feb 21, 2024
…17836 (#18109) PR #17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor Signed-off-by: mlok <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 24, 2024
…rvice (sonic-net#17836) * Update service_checker.py Signed-off-by: Abhishek Dosi <[email protected]>
Cherry-pick PR to 202305: #18170 |
StormLiangMS
pushed a commit
that referenced
this pull request
Feb 25, 2024
…rvice (#17836) (#18170) * Update service_checker.py Signed-off-by: Abhishek Dosi <[email protected]> Co-authored-by: abdosi <[email protected]>
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
…17836 (sonic-net#18109) PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor Signed-off-by: mlok <[email protected]>
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
…17836 (sonic-net#18109) PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor Signed-off-by: mlok <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Apr 5, 2024
…17836 (sonic-net#18109) PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor Signed-off-by: mlok <[email protected]>
mssonicbld
pushed a commit
that referenced
this pull request
Apr 8, 2024
…17836 (#18109) PR #17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor Signed-off-by: mlok <[email protected]>
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…rvice (sonic-net#17836) * Update service_checker.py Signed-off-by: Abhishek Dosi <[email protected]>
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
[chassis] update service_checker module to handle database-chassis service (sonic-net#17836)
mlok-nokia
added a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…17836 (sonic-net#18109) PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor Signed-off-by: mlok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved for 202305 Branch
Approved for 202311 Branch
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
Created PR to 202305 Branch
Created PR to 202311 Branch
Included in Chassis for 202205 Branch
Indicate PR is already in MSFT repo 202205 branch
Included in 202305 Branch
Included in 202311 Branch
P0
Priority of the issue
Request for 202305 Branch
Request for 202311 Branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added change service_checker.py to add
database-chassis
docker also as expected running container for chassis supervisor. Change is inline with this chnage: https://github.com/sonic-net/sonic-buildimage/blob/master/files/image_config/monit/container_checker#L82Microsoft ADO: 26655378
Why I did:
service_checker.py is used for critical process monitoring and
database-chassis
is critical service on Chasiss architecture on Supervisor.How I verify:
Manual Veriifcation.