-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mellanox] Add cpldupdate utility to SONiC image #1746
Conversation
platform/mellanox/mft/Makefile
Outdated
touch $(MFT_NAME)/DEBS/$* | ||
mv $(MFT_NAME)/SDEBS/ubuntu-drivers/3.16.0/$(DERIVED_TARGETS) $(MFT_NAME)/DEBS/$* $(DEST) | ||
touch $(MFT_NAME)/DEBS/* | ||
mv $(MFT_NAME)/SDEBS/ubuntu-drivers/3.16.0/kernel-mft-dkms_4.5.0-$(KVERSION)_all.deb $(MFT_NAME)/DEBS/* $(DEST) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel [](start = 44, length = 6)
kernel [](start = 44, length = 6)
Since the rule is a pattern match one, why you need to specify a special target? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel-mft-dkms and mft-oem are in DERIVED_TARGETS, but they are placed in different locations, so i specify that kernel-mft-dkms should be moved from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments.
15034f0
to
8a5f233
Compare
Signed-off-by: Stepan Blyschak <[email protected]>
8a5f233
to
d197238
Compare
retest this please |
bb383be2 [Dynamic Buffer Calc][Mellanox] Bug fixes and enhancements for the lua plugins for buffer pool calculation and headroom checking (sonic-net#1781) f949dfe9 [Dynamic Buffer Calc] Avoid creating lossy PG for admin down ports during initialization (sonic-net#1776) def0a914 Fix config prompt question issue (sonic-net#1799) 21f97506 [ci]: Merge azure pipelines from master to 202012 branch (sonic-net#1764) a83a2a42 [vstest]: add dvs_route fixture 849bdf9c [Mux] Add support for mux metrics to State DB (sonic-net#1757) 386de717 [qosorch] Dot1p map list initialization fix (sonic-net#1746) f99abdca [sub intf] Port object reference count update (sonic-net#1712) 4a00042d [vstest/nhg]: use dvs_route fixture to make test_nhg more robust Signed-off-by: Stephen Sun <[email protected]>
- For DOT1P QOS map, the map list was not initialized correctly. So "color" field in the key was sending garbage. Because of this, orchagent serialization function is unable to translate and serialize the attribute value properly and returns warning. During subsequent operation which comes with a different garbage, this was treated as a different "color" and syncd/SAI returns error saying "modification not implemented". This is fixed by initializing the dotp1 map list attribute. Signed-off-by: vedganes <[email protected]>
Signed-off-by: Stepan Blyschak [email protected]
- What I did
Included mft-oem debian package, which contains some useful utilities for Mellanox platform, such as cpldupdate
- How I did it
Added target mft-oem alongside with mft package in platforms/mellanox/mft.mk;
added mft-oem to $(SONIC_ONE_IMAGE)_INSTALLS
- How to verify it
Try to use cpldupdate utility
- Description for the changelog
Add cpldupdate utility to SONiC image