Revert "[swss/syncd] remove dependency on interfaces-config.service (… #17367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @yxieca could you help to comment if any impact on warm-reboot / fast-reboot with this change? |
|
@yxieca @StormLiangMS please review. this is needed for 202305 and up |
yxieca
approved these changes
Dec 7, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 7, 2023
…onic-net#13084) (sonic-net#14341)" (sonic-net#15094) (sonic-net#17367) This reverts commit 499f57a. Co-authored-by: Nazarii Hnydyn <[email protected]>
|
Cherry-pick PR to 202311: #17447 |
Merged
10 tasks
|
@StormLiangMS Tested on top of 202305 commit 2b8efdb |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 8, 2023
…onic-net#13084) (sonic-net#14341)" (sonic-net#15094) (sonic-net#17367) This reverts commit 499f57a. Co-authored-by: Nazarii Hnydyn <[email protected]>
|
Cherry-pick PR to 202305: #17461 |
Merged
10 tasks
mssonicbld
added a commit
that referenced
this pull request
Dec 8, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
mssonicbld
added a commit
that referenced
this pull request
Dec 9, 2023
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#13084) (#14341)" (#15094)
This reverts commit 499f57a.
Why I did it
This is port from 202211 -
https://github.com/sonic-net/sonic-buildimage/pull/15094.The problematic change was done on 202211 but not in later branches or master.
Work item tracking
How I did it
Cherry-pick
How to verify it
Run basic sanity tests. Ensure swss starts after interfaces config.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)