Remove fan LED initialization from led_control plugins for Arista 7050-QX32, 7050-QX-32S #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0-QX32, 7050-QX-32S
lguohan
approved these changes
May 22, 2018
hui-ma
approved these changes
May 22, 2018
BasimShalata
added a commit
to BasimShalata/sonic-buildimage
that referenced
this pull request
Aug 4, 2021
This PR contains the following commits: 54b74a2 2021-08-04 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (sonic-net#1657) 0d53b7a 2021-08-03 [sonic_installer] don't print errors when installing an image not supporting app ext (sonic-net#1719) 394e2fb 2021-08-03 Implement script null_route_helper (sonic-net#1737) dd01b56 2021-08-02 disk_check updates: (sonic-net#1736) 8a74d03 2021-07-30 [CLI][show][bgp] Fix the show ip bgp network command (sonic-net#1733) 679a4ba 2021-07-30 [MACsec]: Allow upgrade-docker for macsec container (sonic-net#1716) e9c73e8 2021-07-28 [CLI][MPLS][Show] Added multi ASIC support for 'show mpls command'. Signed-off-by: Basim Shalata <[email protected]>
5 tasks
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Aug 6, 2021
This PR contains the following commits: 54b74a2 2021-08-04 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (#1657) 0d53b7a 2021-08-03 [sonic_installer] don't print errors when installing an image not supporting app ext (#1719) 394e2fb 2021-08-03 Implement script null_route_helper (#1737) dd01b56 2021-08-02 disk_check updates: (#1736) 8a74d03 2021-07-30 [CLI][show][bgp] Fix the show ip bgp network command (#1733) 679a4ba 2021-07-30 [MACsec]: Allow upgrade-docker for macsec container (#1716) e9c73e8 2021-07-28 [CLI][MPLS][Show] Added multi ASIC support for 'show mpls command'. Signed-off-by: Basim Shalata <[email protected]>
judyjoseph
added a commit
that referenced
this pull request
Aug 7, 2021
8b149a3 Load the database global_db only once for show cli (#1712) cd0e560 [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739) b595ba6 [fast-reboot] revert the change of disabling counter polling before fast-reboot (#1744) 8518820 [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734) 2213774 [CLI][show][bgp] Fix the show ip bgp network command (#1733) 3526507 [configlet] Python3 compatible syntax for extracting a key from the dict (#1721) 5b56b97 [sonic_installer] don't print errors when installing an image not supporting app ext (#1719) a581955 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (#1657)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…sonic-net#1733) Signed-off-by: Ze Gan <[email protected]>
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In aristanetworks/sonic@6e35bf5, the mapping of color values changed for the 7050-QX, causing the values in led_control.py to set the LEDs to yellow/orange rather than green as they had previously. However, also in this commit, Arista also began initializing the fan LEDs to green rather than off, as they had previously. Therefore, there is no longer a need to initialize the fan LEDs to green in led_control.py.
Similar changes were implemented for the 7050-QX-32-S here: aristanetworks/sonic@561f785, however there was no remapping of colors, so these devices were not impacted. I am also removing the fan LED initialization for the SKU because it is now also redundant. #