Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202211] Add yang model for scheduler in PORT_QOS_MAP (#16244) #16359

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Aug 31, 2023

Why I did it

Backport #16244 to 202211

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs stephenxs changed the title Add yang model for scheduler in PORT_QOS_MAP (#16244) [202211] Add yang model for scheduler in PORT_QOS_MAP (#16244) Aug 31, 2023
@liat-grozovik liat-grozovik marked this pull request as ready for review August 31, 2023 16:45
@liat-grozovik
Copy link
Collaborator

@ganglyu @dgsudharsan can you please help to approve the PR as of cherry pick conflicts?
@StormLiangMS appreciate if you can merge it

@liat-grozovik
Copy link
Collaborator

@StormLiangMS can you please help to merge?

@stephenxs
Copy link
Collaborator Author

It can cause the following error message when the field is configured

2023-08-14.03:38:12.525017|SCHEDULER|port_scheduler|SET|type:STRICT|pir:25000000
2023-08-14.03:38:13.664406|PORT_QOS_MAP|Ethernet124|SET|dscp_to_tc_map:AZURE|pfc_enable:3,4|pfc_to_pg_map:AZURE|pfc_to_queue_map:AZURE|pfcwd_sw_enable:3,4|tc_to_pg_map:AZURE|tc_to_queue_map:AZURE|scheduler:port_scheduler
2023-08-14.03:39:31.630928|PORT_QOS_MAP|Ethernet25|DEL
2023-08-14.03:39:31.897676|QUEUE|Ethernet20|6|DEL
Aug 14 07:03:48.071609 r-panther-13 ERR sonic_yang: Data Loading Failed:All Keys are not parsed in PORT_QOS_MAP#012dict_keys(['Ethernet124'])#012exceptionList:["'scheduler'"]
Aug 14 07:03:48.071835 r-panther-13 ERR ConfigMgmt: Data Loading Failed#012All Keys are not parsed in PORT_QOS_MAP#012dict_keys(['Ethernet124'])#012exceptionList:["'scheduler'"]

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 7ea54f5 into sonic-net:202211 Sep 19, 2023
15 checks passed
@ganglyu
Copy link
Contributor

ganglyu commented Sep 19, 2023

It can cause the following error message when the field is configured

2023-08-14.03:38:12.525017|SCHEDULER|port_scheduler|SET|type:STRICT|pir:25000000
2023-08-14.03:38:13.664406|PORT_QOS_MAP|Ethernet124|SET|dscp_to_tc_map:AZURE|pfc_enable:3,4|pfc_to_pg_map:AZURE|pfc_to_queue_map:AZURE|pfcwd_sw_enable:3,4|tc_to_pg_map:AZURE|tc_to_queue_map:AZURE|scheduler:port_scheduler
2023-08-14.03:39:31.630928|PORT_QOS_MAP|Ethernet25|DEL
2023-08-14.03:39:31.897676|QUEUE|Ethernet20|6|DEL
Aug 14 07:03:48.071609 r-panther-13 ERR sonic_yang: Data Loading Failed:All Keys are not parsed in PORT_QOS_MAP#012dict_keys(['Ethernet124'])#012exceptionList:["'scheduler'"]
Aug 14 07:03:48.071835 r-panther-13 ERR ConfigMgmt: Data Loading Failed#012All Keys are not parsed in PORT_QOS_MAP#012dict_keys(['Ethernet124'])#012exceptionList:["'scheduler'"]

Why do you have scheduler in PORT_QOS_MAP table? If it's from sonic-buildimage repo, can you show me the code?

@stephenxs stephenxs deleted the 202211-yang-port-scheduler branch September 19, 2023 02:07
@stephenxs
Copy link
Collaborator Author

It can cause the following error message when the field is configured

2023-08-14.03:38:12.525017|SCHEDULER|port_scheduler|SET|type:STRICT|pir:25000000
2023-08-14.03:38:13.664406|PORT_QOS_MAP|Ethernet124|SET|dscp_to_tc_map:AZURE|pfc_enable:3,4|pfc_to_pg_map:AZURE|pfc_to_queue_map:AZURE|pfcwd_sw_enable:3,4|tc_to_pg_map:AZURE|tc_to_queue_map:AZURE|scheduler:port_scheduler
2023-08-14.03:39:31.630928|PORT_QOS_MAP|Ethernet25|DEL
2023-08-14.03:39:31.897676|QUEUE|Ethernet20|6|DEL
Aug 14 07:03:48.071609 r-panther-13 ERR sonic_yang: Data Loading Failed:All Keys are not parsed in PORT_QOS_MAP#012dict_keys(['Ethernet124'])#012exceptionList:["'scheduler'"]
Aug 14 07:03:48.071835 r-panther-13 ERR ConfigMgmt: Data Loading Failed#012All Keys are not parsed in PORT_QOS_MAP#012dict_keys(['Ethernet124'])#012exceptionList:["'scheduler'"]

Why do you have scheduler in PORT_QOS_MAP table? If it's from sonic-buildimage repo, can you show me the code?

This is done in our internal QA test via redis-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants