Add pensando platform #15978

ashwin-h · 2023-07-27T06:15:33Z

This commit adds support for pensando asic called ELBA. ELBA is used in pci based cards and in smartswitches.

Why I did it

This commit introduces pensando platform which is based on ELBA ASIC.

Work item tracking

Microsoft ADO (number only):

How I did it

Created platform/pensando folder and created makefiles specific to pensando.
This mainly creates pensando docker (which OEM's need to download before building an image) which has all the userspace to initialize and use the DPU (ELBA ASIC).
Output of the build process creates two images which can be used from ONIE and goldfw.
Recommendation is use to use ONIE.

How to verify it

Load the SONiC image via ONIE or goldfw and make sure the interfaces are UP.

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

master

Description for the changelog

Add pensando platform support.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

KrisNey-MSFT · 2023-07-31T21:14:41Z

Discussed in Monday SS Architecture call - @lguohan and team to review.

Use case for gold - if something goes wrong or if we want to revert to a non-SONiC / non-ONIE image (backup to a backup)
Use case for ONIE - most cases
When the hardware ships, the image by default will be ONIE, from which we can install SONiC.
There will be an option to 'reset' the FW on the DPU, we can choose goldfw or ONIE at that point.

lguohan · 2023-08-07T17:17:02Z

device/pensando/arm64-elba-asic-r0/pmon_daemon_control.json

+    "skip_ledd": true,
+    "skip_psud": true,
+    "skip_syseepromd": false,
+    "skip_xcvrd": true,


i do not knw why we skip xcrvd and pcied

This is still work in progress and will be enabled later.

lguohan · 2023-08-07T17:17:20Z

device/pensando/arm64-elba-asic-r0/config_db.json

+        "dsc1": {},
+        "dsc1|10.0.0.6/31": {}
+    },
+    "KDUMP": {


not sure why we need the config_db.json here.

This was added a refernce config_db.json similar to the one maintained by other platforms for ex: https://github.com/sonic-net/sonic-buildimage/blob/master/device/tencent/x86_64-tencent_tcs8400-r0/config_db.TCS8400-24CC8CD.json

We can delete this.

Deleted config_db.json

lguohan · 2023-08-07T17:18:27Z

device/pensando/arm64-elba-asic-r0/Pensando-elba/port_config.ini

@@ -0,0 +1,3 @@
+# name          lanes		alias		speed	autoneg	fec
+Ethernet1	29		Ethernet1	100000	on	rs


the lanes should be 4 lanes, btw, for smartswitch one isn't the link should be 1x200G port?

Corrected the lanes.

lguohan · 2023-08-07T17:19:56Z

dockers/docker-orchagent/orchagent.sh

@@ -64,6 +64,9 @@ elif [ "$platform" == "mellanox" ]; then
    ORCHAGENT_ARGS+=""
 elif [ "$platform" == "innovium" ]; then
    ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
+elif [ "$platform" == "pensando" ]; then
+    MAC_ADDRESS=$(ip link show oob_mnic0 | grep ether | awk '{print $2}')


why cannot we rename oob_mnic0 to eth0?

its named as oob_mnic0 across pensando fw in multiple places.

git grep eth0

We will check if we can have alternate interface with name eth0 which points to oob_mnic0

Renamed eth0 to oob_mnic0

lguohan · 2023-08-07T17:25:26Z

files/build_templates/sonic_debian_extension.j2

+sudo LANG=C DOCKER_HOST="$DOCKER_HOST" chroot $FILESYSTEM_ROOT docker load -i boot/dpu_sw.tar
+sudo LANG=C chroot $FILESYSTEM_ROOT rm -f boot/dpu_sw.tar
+
+#Disable rc.local


why do we need to disable rc.local here?

We are seeing multiple errors on console with rc.local enabled. Also we don't need most of the functionality done in that script.

We will disable in this initial change and revisit this later.

We are seeing continuous error messages as below. So disabled it for now. It can be enabled later

[ 1561.958120] rc.local[18331]: + SONIC_VERSION=dpu.0-dirty-20230922.131734 [ 1561.958192] rc.local[18331]: + FIRST_BOOT_FILE=/host/image-dpu.0-dirty-20230922.131734/platform/firsttime [ 1561.958261] rc.local[18331]: + SONIC_CONFIG_DIR=/host/image-dpu.0-dirty-20230922.131734/sonic-config [ 1561.958329] rc.local[18331]: + SONIC_ENV_FILE=/host/image-dpu.0-dirty-20230922.131734/sonic-config/sonic-environment [ 1561.958399] rc.local[18331]: + [ -d /host/image-dpu.0-dirty-20230922.131734/sonic-config -a -f /host/image-dpu.0-dirty-20230922.131734/sonic-config/sonic-environment ] [ 1561.958467] rc.local[18331]: + logger SONiC version dpu.0-dirty-20230922.131734 starting up... [ 1561.958536] rc.local[18331]: + grub_installation_needed= [ 1561.958613] rc.local[18331]: + [ ! -e /host/machine.conf ] [ 1561.958825] rc.local[18320]: + blkid [ 1561.959095] rc.local[18338]: + blkid [ 1561.959343] rc.local[18321]: + grep ONIE-BOOT [ 1561.959636] rc.local[18339]: + grep ONIE-BOOT [ 1561.959882] rc.local[18322]: + head -n 1 [ 1561.960187] rc.local[18340]: + head -n 1 [ 1561.960426] rc.local[18323]: + awk {print $1} [ 1561.960800] rc.local[18341]: + awk {print $1} [ 1561.961066] rc.local[18324]: + sed -e s/:.*$// [ 1561.961401] rc.local[18342]: + sed -e s/:.*$// [ 1561.961534] rc.local[18313]: + onie_dev= [ 1561.961611] rc.local[18313]: + mkdir -p /mnt/onie-boot [ 1561.961685] rc.local[18313]: + mount /mnt/onie-boot [ 1561.961916] rc.local[18331]: + onie_dev= [ 1561.961997] rc.local[18331]: + mkdir -p /mnt/onie-boot [ 1561.962070] rc.local[18331]: + mount /mnt/onie-boot [ 1561.962295] rc.local[18326]: mount: /mnt/onie-boot: can't find in /etc/fstab. [ 1561.962639] rc.local[18344]: mount: /mnt/onie-boot: can't find in /etc/fstab. [ 1561.962833] rc.local[18313]: + onie_grub_cfg=/mnt/onie-boot/onie/grub/grub-machine.cfg [ 1561.962908] rc.local[18313]: + [ ! -e /mnt/onie-boot/onie/grub/grub-machine.cfg ] [ 1562.304038] rc.local[18313]: + log_migration /mnt/onie-boot/onie/grub/grub-machine.cfg not found [ 1562.304128] rc.local[18313]: + echo /mnt/onie-boot/onie/grub/grub-machine.cfg not found [ 1562.304200] rc.local[18313]: + migrate_nos_configuration [ 1562.304270] rc.local[18313]: + rm -rf /host/migration [ 1562.304338] rc.local[18313]: + mkdir -p /host/migration [ 1562.304822] rc.local[18331]: + onie_grub_cfg=/mnt/onie-boot/onie/grub/grub-machine.cfg [ 1562.304911] rc.local[18331]: + [ ! -e /mnt/onie-boot/onie/grub/grub-machine.cfg ] [ 1562.304994] rc.local[18331]: + log_migration /mnt/onie-boot/onie/grub/grub-machine.cfg not found [ 1562.305063] rc.local[18331]: + echo /mnt/onie-boot/onie/grub/grub-machine.cfg not found [ 1562.305132] rc.local[18331]: + migrate_nos_configuration

lguohan · 2023-08-07T17:44:02Z

files/build_templates/sonic_debian_extension.j2

+#if we don't start pciemgrd early pcie timeout happens and server reboots.
+#pciemgrd runs as part of dpu docker. So load this at build time itself.
+sudo LANG=C DOCKER_HOST="$DOCKER_HOST" chroot $FILESYSTEM_ROOT docker load -i boot/dpu_sw.tar
+sudo LANG=C chroot $FILESYSTEM_ROOT rm -f boot/dpu_sw.tar


this seems not from framework, we should follow the sonic framework instead of doing this approach.

What is SONiC framework here ? Can you please share the documentation/code-reference for the same as i am not clear what is the ask here.

@liushilongbuaa , this is pre-built docker, the tar file is pre-built, they just need to load into the image, wonder if there is way to plug this into the build framework.

Currently, we have SONIC_SIMPLE_DOCKER_IMAGES/DOCKER_IMAGES/DOCKER_DBG_IMAGES.
They all need to be built from Dockerfile.
We need a new type PREBUILT_DOCKER_IMAGES to download from a URL.

boot/dpu_sw.tar is generated by which file?

@liushilongbuaa dpu_sw.tar is a artifact generated by pensando build process and given to the customer. This currently is part of dpu debian pkg which part of this change (platform/pensando/dpu/debian).

Hi @ashwin-h , I created a draft PR to support downloaded docker image.
https://github.com/sonic-net/sonic-buildimage/pull/16519/files
So, you can remove the platform/pensando/dpu folder and dpu.mk.
Instead, you need to add a platform/pensando/docker-dpu.mk and platform/pensando/docker-dpu.dep.
The other details can be included in your docker-dpu image. ex: mkdir/mount

I will test it on vs image. Please @me if any problems.

@ashwin-h , Why don't you provide a Dockerfile for dpu?
You can download and install your debian package in that Dockerfile.
Something private can hide in the debian package.

Included prebuilt docker now. Removed this.

lguohan · 2023-08-07T17:47:21Z

files/dsc/install_debian.j2

+label main
+	kernel /$image_dir/boot/vmlinuz-5.10.0-18-2-arm64
+	initrd /$image_dir/boot/initrd.img-5.10.0-18-2-arm64
+	devicetree /$image_dir/boot/elba-asic-psci.dtb


can you convert all tabs to spaces?

lguohan · 2023-08-07T17:53:34Z

platform/pensando/dsc-drivers/src/drivers/linux/pciesvc/README.md

+
+## Overview
+
+This driver module is a companion to the kpcimgr driver.  This module


where is this driver being packaged into the image? i do not see it.

We are not loading this currently. Will be adding functionality to load this later.

lguohan · 2023-08-07T17:56:05Z

exit 0

please convert all tabs to spaces

Refers to: platform/pensando/dsc-drivers/src/drivers/linux/pciesvc/tools/reloc_check:29 in 1d61f63. [](commit_id = 1d61f63, deletion_comment = False)

lguohan · 2023-08-07T17:57:04Z

    libgrpc++-dev \

if we add this, can you make proper comment on this, this is not for SAI 3.7, right?

Refers to: sonic-slave-buster/Dockerfile.j2:347 in 1d61f63. [](commit_id = 1d61f63, deletion_comment = False)

lguohan · 2023-08-07T18:00:00Z

platform/pensando/dsc-drivers/debian/compat

@@ -0,0 +1 @@
+8


why is this 8? not 10?

lguohan · 2023-08-07T18:00:50Z

platform/pensando/dsc-drivers/debian/control

+Source: ionic
+Section: main
+Priority: extra
+Maintainer: Guohan Lu <[email protected]>


can we get a proper name for maintainer? someone from amd? not sure I am the maintainer for this package.

lguohan · 2023-08-07T18:02:31Z

platform/pensando/dpu/debian/changelog

@@ -0,0 +1,5 @@
+dpu (1.0.0) UNRELEASED; urgency=low


is dpu a docker package? why do we need debian packaging for this one?

@ashwin-h , Can we delete this package and dpu folder?
For docker start:
files/build_templates/sonic_debian_extension.j2:43:DOCKER_CTL_SCRIPT="$DOCKER_CTL_DIR/docker.sh"
files/build_templates/sonic_debian_extension.j2:70:sudo cp $DOCKER_SCRIPTS_DIR/docker "$FILESYSTEM_ROOT/$DOCKER_CTL_SCRIPT"
files/build_templates/sonic_debian_extension.j2:75: sudo chroot $FILESYSTEM_ROOT $DOCKER_CTL_SCRIPT start
files/build_templates/sonic_debian_extension.j2:854: sudo chroot $FILESYSTEM_ROOT $DOCKER_CTL_SCRIPT stop

files/docker/docker

Deleted dpu directory.

lguohan · 2023-08-07T18:04:17Z

device/pensando/arm64-elba-asic-r0/plugins/ssd_util.py

+#  - StorFly
+#  - Virtium
+
+try:


@prgeor , can you check what else plugins are missing from platform side?

@ashwin-h please add support for thermalctld, psud, pcied, system eeprom, chassis.py

We will enable all the plugins when we enable pmon functionality later.

@prgeor has this been answered satisfactorily for you?

build_debian.sh

prgeor · 2023-08-29T15:34:22Z

platform/pensando/dsc-drivers/src/drivers/linux/eth/ionic/ionic_fw.c

+}
+
+int ionic_firmware_update(struct ionic_lif *lif, const struct firmware *fw)
+{


@ashwin-h How is the ionic fw update exposed to userspace?

@ashwin-h How is the ionic fw update exposed to userspace?

@shanshri - does this need to be answered?

@KrisNey-MSFT this code is a part of dsc-drivers which are pensando specific. This is not related to any sonic related firmware update

prgeor · 2023-08-29T15:38:26Z

device/pensando/arm64-elba-asic-r0/plugins/ssd_util.py

+    def __init__(self, diskdev):
+
+        self.dev = diskdev
+        try:
+            self.model = ("emmc {}".format(open(MMC_DATA_PATH.format("name")).read())).replace("\n", "")
+            self.serial = open(MMC_DATA_PATH.format("serial")).read().replace("\n", "")
+            self.firmware = open(MMC_DATA_PATH.format("fwrev")).read().replace("\n", "")
+            value =  open(MMC_DATA_PATH.format("life_time")).read().replace("\n", "")
+            [lifetime_a, lifetime_b] = [int(val, 16) for val in value.split()]
+            lifetime = lifetime_a if lifetime_a >= lifetime_b else lifetime_b
+            self.health = float(100 - (lifetime*10))


@ashwin-h for EMMC please use https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/sonic_ssd/ssd_emmc.py

@ashwin-h for EMMC please use https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/sonic_ssd/ssd_emmc.py

@shanshri - did this (above) get used per @prgeor 's request?

We will address these things in the when will enable pmon in upstream

@shanshri noted

prgeor

@ashwin-h Please add support for basic platform support https://github.com/sonic-net/sonic-platform-common/tree/master/sonic_platform_base

For eg. Need to add https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/component_base.py that will be needed to support firmware upgrade of various on board platform components.

linux-foundation-easycla · 2023-09-05T09:40:12Z

The committers listed above are authorized under a signed CLA.

✅ login: shanshri / name: Shantanu Shrivastava (31f5822, f32fc26, 7190c62, 4e8ee73, 9c67332, e43b1fb, 23ce5f4, 986c566, 1ace1b4, 4c19e51)

KrisNey-MSFT · 2023-09-11T21:38:50Z

PR has been discussed, AI is to address Comments. And a method to add the docker container...
Also update the kernel
Need a URL from where to download the docker - or some such pointer?

prgeor · 2023-09-11T23:20:08Z

platform/pensando/dpu/systemd/dpu.service

@@ -0,0 +1,17 @@
+[Unit]


@ashwin-h what is the role of this dpu service?

This service is starting docker-dpu.

KrisNey-MSFT · 2023-09-25T19:02:45Z

[like] Kristina Moore reacted to your message:

________________________________ From: Shantanu Shrivastava ***@***.***> Sent: Friday, September 22, 2023 5:08:12 PM To: sonic-net/sonic-buildimage ***@***.***> Cc: Kristina Moore ***@***.***>; Comment ***@***.***> Subject: Re: [sonic-net/sonic-buildimage] Add pensando platform (PR #15978) @shanshri commented on this pull request.

________________________________ In device/pensando/arm64-elba-asic-r0/plugins/ssd_util.py<#15978 (comment)>:

@@ -0,0 +1,100 @@

+# +# ssd_generic.py +# +# Generic implementation of the SSD health API +# SSD models supported: +# - InnoDisk +# - StorFly +# - Virtium + +try: We will enable all the plugins when we enable pmon functionality later. — Reply to this email directly, view it on GitHub<#15978 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6BQQV5RMVF6P6GQ2JDX3XAXZANCNFSM6AAAAAA2ZSN7NQ>. You are receiving this because you commented.Message ID: ***@***.***>

KrisNey-MSFT · 2023-10-02T21:20:33Z

@shanshri - can you take a look at this tonight and report back please?

shanshri · 2023-10-03T19:19:49Z

@shanshri - can you take a look at this tonight and report back please?

@KrisNey-MSFT
Our prebuilt docker is created from scratch but when I try to build sonic docker on top of it I am running into issues as sonic build infra expects utilities like apt-get, dpkg. I am looking for a way to build it cleanly.

KrisNey-MSFT · 2023-10-03T21:01:35Z

[like] Kristina Moore reacted to your message:

…

________________________________ From: Shantanu Shrivastava ***@***.***> Sent: Tuesday, October 3, 2023 7:20:01 PM To: sonic-net/sonic-buildimage ***@***.***> Cc: Kristina Moore ***@***.***>; Mention ***@***.***> Subject: Re: [sonic-net/sonic-buildimage] Add pensando platform (PR #15978) @shanshri<https://github.com/shanshri> - can you take a look at this tonight and report back please? @KrisNey-MSFT<https://github.com/KrisNey-MSFT> Our prebuilt docker is created from scratch but when I try to build sonic docker on top of it I am running into issues as sonic build infra expects utilities like apt-get, dpkg. I am looking for a way to build it cleanly. — Reply to this email directly, view it on GitHub<#15978 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6AYE4QAW53K6MJ5ZKLX5RQODAVCNFSM6AAAAAA2ZSN7NSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVGU3TQNZYHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

liushilongbuaa · 2023-11-16T12:08:07Z

d5863e4#diff-6b0c1444ee324b0a060487f8cfefdf2c451bec1b699a653e6f7430b761d9f5e7
I created a commit to have a test build.

There are two concerns:

Use bullseye instead of buster. Because in master branch buster is deprecated.
Please confirm platform/pensando/docker-dpu.mk *_RUN_OPT variables. Are they really needed or copied from others.
libsai_1.10.1-0_arm64.deb is missing.

shanshri · 2023-11-20T20:13:00Z

d5863e4#diff-6b0c1444ee324b0a060487f8cfefdf2c451bec1b699a653e6f7430b761d9f5e7 I created a commit to have a test build.

There are two concerns:

Use bullseye instead of buster. Because in master branch buster is deprecated. ===> Made it to bullseye

Please confirm platform/pensando/docker-dpu.mk *_RUN_OPT variables. Are they really needed or copied from others. ===> Remove OPT variables

libsai_1.10.1-0_arm64.deb is missing. ===> Added libsai url in platform/pensando/sdk.mk

KrisNey-MSFT · 2023-11-21T21:21:55Z

@ashwin-h Please add support for basic platform support https://github.com/sonic-net/sonic-platform-common/tree/master/sonic_platform_base

For eg. Need to add https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/component_base.py that will be needed to support firmware upgrade of various on board platform components.

@prgeor and @shanshri - did this get addressed? TY

shanshri · 2023-11-22T04:22:28Z

@ashwin-h Please add support for basic platform support https://github.com/sonic-net/sonic-platform-common/tree/master/sonic_platform_base

For eg. Need to add https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/component_base.py that will be needed to support firmware upgrade of various on board platform components.

@ashwin-h Please add support for basic platform support https://github.com/sonic-net/sonic-platform-common/tree/master/sonic_platform_base
For eg. Need to add https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/component_base.py that will be needed to support firmware upgrade of various on board platform components.

@prgeor and @shanshri - did this get addressed? TY

@KrisNey-MSFT We are not supporting for firmware upgrade in this PR. We will take care of it later. Thanks.

liushilongbuaa · 2023-11-24T06:35:59Z

platform/pensando/sdk.mk

+# Pensando SAI
+PENSANDO_SAI = libsai_1.10.1-0_arm64.deb
+PENSANDO_SAI_DEV = libsai-dev_1.10.1-0_arm64.deb
+$(PENSANDO_SAI)_URL = https://github.com/pensando/dsc-artifacts/blob/main/libsai_1.10.1-0_arm64.deb?raw=true


The libsai package don't have sai_query_api_version function.
It is required. @ashwin-h

liushilongbuaa · 2023-11-24T07:05:42Z

Hi @ashwin-h , I have some comments in this link:
46856c8
And libsai package don't have sai_query_api_version function.

KrisNey-MSFT · 2023-11-27T22:19:21Z

@lguohan @liushilongbuaa - this has been rebased and we feel it is ready to go, could we try again?

liushilongbuaa · 2023-11-28T02:32:58Z

dockers/docker-pde/syncd_init_common.sh

@@ -216,6 +216,10 @@ config_syncd_innovium()
    mkdir -p $II_ROOT
 }

+config_syncd_pensando()


This function is added but not called.

@ashwin-h , @KrisNey-MSFT . Others LGTM.
Please complete EasyCLA.

This function is added but not called.

Removed the function

@ashwin-h , @KrisNey-MSFT . Others LGTM. Please complete EasyCLA.

Done

liushilongbuaa · 2023-11-28T07:26:01Z

LGTM.
@xumia , @lguohan , please help review.

This commit adds support for pensando asic called ELBA. ELBA is used in pci based cards and in smartswitches.

KrisNey-MSFT · 2023-11-29T20:49:33Z

Sorry if I’ve lost track :) Could we list the functionality that this image can execute? 425-876-2040 cell

________________________________ From: Shantanu Shrivastava ***@***.***> Sent: Tuesday, November 28, 2023 1:29:10 AM To: sonic-net/sonic-buildimage ***@***.***> Cc: Kristina Moore ***@***.***>; Mention ***@***.***> Subject: Re: [sonic-net/sonic-buildimage] Add pensando platform (PR #15978) @shanshri commented on this pull request.

________________________________ In dockers/docker-pde/syncd_init_common.sh<#15978 (comment)>:

@@ -216,6 +216,10 @@ config_syncd_innovium()

mkdir -p $II_ROOT } +config_syncd_pensando() @ashwin-h<https://github.com/ashwin-h> , @KrisNey-MSFT<https://github.com/KrisNey-MSFT> . Others LGTM. Please complete EasyCLA. Done — Reply to this email directly, view it on GitHub<#15978 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6AST7XPOIPDQXSX75TYGWVGNAVCNFSM6AAAAAA2ZSN7NSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJSGQZDONRXGM>. You are receiving this because you were mentioned.Message ID: ***@***.***>

shanshri · 2023-11-30T04:55:51Z

Sorry if I’ve lost track :) Could we list the functionality that this image can execute? 425-876-2040 cell
________________________________ From: Shantanu Shrivastava @.> Sent: Tuesday, November 28, 2023 1:29:10 AM To: sonic-net/sonic-buildimage @.> Cc: Kristina Moore @.>; Mention @.> Subject: Re: [sonic-net/sonic-buildimage] Add pensando platform (PR #15978) @shanshri commented on this pull request.
________________________________ In dockers/docker-pde/syncd_init_common.sh<#15978 (comment)>:
@@ -216,6 +216,10 @@ config_syncd_innovium()
mkdir -p $II_ROOT } +config_syncd_pensando() @ashwin-h https://github.com/ashwin-h , @KrisNey-MSFT https://github.com/KrisNey-MSFT . Others LGTM. Please complete EasyCLA. Done — Reply to this email directly, view it on GitHub<#15978 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJSI6AST7XPOIPDQXSX75TYGWVGNAVCNFSM6AAAAAA2ZSN7NSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJSGQZDONRXGM. You are receiving this because you were mentioned.Message ID: @.***>

This commit adds support for pensando asic called ELBA. ELBA is used in pci based cards and in smartswitches. We are trying to get a buildimage for this platform.

prgeor · 2023-12-04T22:21:12Z

@ashwin-h Please add support for basic platform support https://github.com/sonic-net/sonic-platform-common/tree/master/sonic_platform_base
For eg. Need to add https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/component_base.py that will be needed to support firmware upgrade of various on board platform components.

@ashwin-h Please add support for basic platform support https://github.com/sonic-net/sonic-platform-common/tree/master/sonic_platform_base
For eg. Need to add https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/component_base.py that will be needed to support firmware upgrade of various on board platform components.

@prgeor and @shanshri - did this get addressed? TY

@KrisNey-MSFT We are not supporting for firmware upgrade in this PR. We will take care of it later. Thanks.

@shanshri noted

prgeor

LGTM

qiluo-msft · 2023-12-04T22:33:39Z

We can override semgrep since all warnings are about memset in kernel drivers, which is actually not available.

ashwin-h requested review from qiluo-msft and lguohan as code owners July 27, 2023 06:15

ashwin-h force-pushed the dpu branch from cb781ec to 1d61f63 Compare July 27, 2023 06:25

lguohan reviewed Aug 7, 2023

View reviewed changes

lguohan reviewed Aug 24, 2023

View reviewed changes

build_debian.sh Outdated Show resolved Hide resolved

prgeor reviewed Aug 29, 2023

View reviewed changes

prgeor requested changes Aug 29, 2023

View reviewed changes

shanshri force-pushed the dpu branch from b12e576 to 453fbd3 Compare September 6, 2023 07:08

prgeor reviewed Sep 11, 2023

View reviewed changes

liushilongbuaa reviewed Nov 24, 2023

View reviewed changes

shanshri force-pushed the dpu branch from 1e9e6c0 to 4a20ae4 Compare November 27, 2023 20:14

liushilongbuaa reviewed Nov 28, 2023

View reviewed changes

liushilongbuaa approved these changes Nov 28, 2023

View reviewed changes

shanshri added 10 commits November 28, 2023 09:21

Add pensando platform

31f5822

This commit adds support for pensando asic called ELBA. ELBA is used in pci based cards and in smartswitches.

correcting lanes in port_config.ini

f32fc26

Addressing review comments

7190c62

Adding prebuilt dpu docker

4e8ee73

Removing dpu directory

9c67332

Addressing comments docker-dpu

e43b1fb

Adding dummy docker-dpu-base URL

23ce5f4

Adding libsai and docker-dpu-base URLs

986c566

Rebasing PR and addressing review comment

1ace1b4

Removing config_syncd_pensando from docker-pde/syncd_init_common.sh

4c19e51

shanshri force-pushed the dpu branch from 649ab51 to 4c19e51 Compare November 28, 2023 09:24

lguohan approved these changes Dec 4, 2023

View reviewed changes

prgeor approved these changes Dec 4, 2023

View reviewed changes

qiluo-msft merged commit ada7c6a into sonic-net:master Dec 4, 2023
18 of 19 checks passed

		@@ -0,0 +1,3 @@
		# name lanes alias speed autoneg fec
		Ethernet1 29 Ethernet1 100000 on rs


		## Overview

		This driver module is a companion to the kpcimgr driver. This module

Add pensando platform #15978

Add pensando platform #15978

Conversation

ashwin-h commented Jul 27, 2023

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

KrisNey-MSFT commented Jul 31, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashwin-h Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liushilongbuaa Sep 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Aug 7, 2023

lguohan commented Aug 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prgeor left a comment

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Sep 5, 2023 • edited Loading

KrisNey-MSFT commented Sep 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KrisNey-MSFT commented Sep 25, 2023 via email

KrisNey-MSFT commented Oct 2, 2023

shanshri commented Oct 3, 2023

KrisNey-MSFT commented Oct 3, 2023 via email

liushilongbuaa commented Nov 16, 2023 • edited Loading

shanshri commented Nov 20, 2023

KrisNey-MSFT commented Nov 21, 2023

shanshri commented Nov 22, 2023

liushilongbuaa Nov 24, 2023 • edited Loading

ashwin-h Aug 24, 2023 •

edited

Loading

liushilongbuaa Sep 13, 2023 •

edited

Loading

linux-foundation-easycla bot commented Sep 5, 2023 •

edited

Loading

liushilongbuaa commented Nov 16, 2023 •

edited

Loading

liushilongbuaa Nov 24, 2023 •

edited

Loading

liushilongbuaa commented Nov 28, 2023 •

edited

Loading