Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:15212] Multiprocessing Manager resources (Queue) to be freed up during task stop #15595

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

mssonicbld
Copy link
Collaborator

Multiprocessing Manager resources (Queue) to be freed up during task stop

Why I did it

Fix for issue #14964

Work item tracking
  • Microsoft ADO (number only):

How I did it

Free up Multiprocessing Manager resource at task stop request
[self.mpmgr.shutdown() in task_stop]

How to verify it

time systemctl stop system-health.service

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Multiprocessing Manager resources (Queue) to be freed up during task stop
@mssonicbld
Copy link
Collaborator Author

Original PR: #15212

@StormLiangMS
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sg893052
Copy link
Contributor

sg893052 commented Jun 27, 2023

/azpw run Azure.sonic-buildiimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 15595 in repo sonic-net/sonic-buildimage

@sg893052
Copy link
Contributor

/azpw run Azure.sonic-buildiimage

@sg893052
Copy link
Contributor

/azpw run Azure.sonic-buildimage

@sg893052
Copy link
Contributor

@vaibhavhd I see you have already cherrypicked the said item(#15212) but the build failed irrelevant to my changes. Could you please re-trigger the build as I don't have the permission.

2023-06-26T05:11:15.1245111Z ##[section]Starting: Run test
2023-06-26T05:11:15.1249959Z ==============================================================================
2023-06-26T05:11:15.1250147Z Task : Command line
2023-06-26T05:11:15.1250235Z Description : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
2023-06-26T05:11:15.1250382Z Version : 2.212.0
2023-06-26T05:11:15.1250458Z Author : Microsoft Corporation
2023-06-26T05:11:15.1250552Z Help : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
2023-06-26T05:11:15.1250698Z ==============================================================================
2023-06-26T05:11:16.4107444Z Generating script.
2023-06-26T05:11:16.4117616Z ========================== Starting Command Output ===========================
2023-06-26T05:11:16.4143635Z [command]/usr/bin/bash --noprofile --norc /agent/_work/_temp/239db6c6-3a13-49e4-901e-c36a9a025c99.sh
2023-06-26T05:11:16.4229569Z Run test
2023-06-26T05:11:16.4230532Z SONiC PR system-level test is powered by SONiC Elastictest, for any issue, please send email to [email protected]
2023-06-26T05:11:16.4231193Z Runtime detailed progress at https://elastictest.org/scheduler/testplan/6499157c747396c5b3a092ca
2023-06-26T05:19:17.4700411Z Test plan utils parameters: Namespace(action='poll', expected_state='EXECUTING', interval=60, test_plan_id='6499157c747396c5b3a092ca', timeout=-1)
2023-06-26T05:19:17.4701261Z Polling progress and status of test plan at https://elastictest.org/scheduler/testplan/6499157c747396c5b3a092ca
2023-06-26T05:19:17.4701807Z Polling interval: 60 seconds
2023-06-26T05:19:17.4702237Z Test plan id: 6499157c747396c5b3a092ca, status: EXECUTING, progress: 0.0%, elapsed: 0 seconds
2023-06-26T05:19:17.4702608Z Test plan id: 6499157c747396c5b3a092ca, status: EXECUTING, progress: 0.0%, elapsed: 60 seconds
2023-06-26T05:19:17.4702950Z Test plan id: 6499157c747396c5b3a092ca, status: EXECUTING, progress: 0.0%, elapsed: 120 seconds
2023-06-26T05:19:17.4703302Z Test plan id: 6499157c747396c5b3a092ca, status: EXECUTING, progress: 0.0%, elapsed: 180 seconds
2023-06-26T05:19:17.4703671Z Test plan id: 6499157c747396c5b3a092ca, status: EXECUTING, progress: 0.0%, elapsed: 240 seconds
2023-06-26T05:19:17.4704030Z Test plan id: 6499157c747396c5b3a092ca, status: EXECUTING, progress: 4.55%, elapsed: 301 seconds
2023-06-26T05:19:17.4704375Z Test plan id: 6499157c747396c5b3a092ca, status: EXECUTING, progress: 4.55%, elapsed: 361 seconds
2023-06-26T05:19:17.4704743Z Test plan id: 6499157c747396c5b3a092ca, status: EXECUTING, progress: 4.55%, elapsed: 421 seconds
2023-06-26T05:19:17.4705638Z Operation failed with exception: Exception('Test plan id: 6499157c747396c5b3a092ca, status: FAILED, result: EXECUTING, Elapsed 481 seconds. Check https://elastictest.org/scheduler/testplan/6499157c747396c5b3a092ca for test plan status')
2023-06-26T05:19:17.4904397Z ##[error]Bash exited with code '3'.
2023-06-26T05:19:17.4998820Z ##[section]Finishing: Run test

@StormLiangMS
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit d0126e6 into sonic-net:202305 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants