Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista][x86_64-arista_7050_qx32] Add Components to platform.json #15252

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented May 29, 2023

Why I did it

This PR fixes the components names and adds the number so that platform API tests can get consistent results to match vs the expected results.
The way to verify /get the platform API results is run the platform API and get the components name for these SKU x86_64-arista_7050_qx32, x86_64-arista_7050_qx32s

Work item tracking
  • Microsoft ADO (number only):
    17397061
    16428955

How I did it

Run the Platfrom API and get the components names

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • [ x] 202205
  • [x ] 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@prgeor
Copy link
Contributor

prgeor commented May 30, 2023

@Staphylo Can you review?

@prgeor
Copy link
Contributor

prgeor commented May 30, 2023

@vdahiya12 can you specify the ADO number in the PR template above?

@vdahiya12
Copy link
Contributor Author

@vdahiya12 can you specify the ADO number in the PR template above?

added

Comment on lines 4 to 20
"components": [
{
"name": "Aboot()"
},
{
"name": "Scd(addr=0000:02:00.0)"
},
{
"name": "Ucd90120A(addr=4-004e)"
},
{
"name": "Ucd90120A(addr=8-004e)"
},
{
"name": "CrowSysCpld(addr=2-0023)"
}
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this product, this is the current list of components:

Scd(addr=0000:04:00.0)
Ucd90120A(addr=6-004e)
Ucd90160(addr=10-004e)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: vaibhav dahiya <[email protected]>
@vdahiya12 vdahiya12 requested a review from Staphylo June 2, 2023 00:02
"components": [],
"components": [
{
"name": "Aboot()"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Aboot component is currently not defined for this product

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, removed

"name": "Ucd90160(addr=10-004e)"
},
{
"name": "CrowSysCpld(addr=2-0023)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This product doesn't have this CrowSysCpld component.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, removed

Signed-off-by: vaibhav dahiya <[email protected]>
Signed-off-by: vaibhav dahiya <[email protected]>
@vdahiya12
Copy link
Contributor Author

@yxieca @lguohan please help merge

@yxieca yxieca merged commit 78c262e into sonic-net:master Jun 22, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 22, 2023
…nic-net#15252)

* [Arista][x86_64-arista_7050_qx32] Add Components to platform.json

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* reformat

Signed-off-by: vaibhav dahiya <[email protected]>

---------

Signed-off-by: vaibhav dahiya <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #15584

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 22, 2023
…nic-net#15252)

* [Arista][x86_64-arista_7050_qx32] Add Components to platform.json

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* reformat

Signed-off-by: vaibhav dahiya <[email protected]>

---------

Signed-off-by: vaibhav dahiya <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #15585

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #15596

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 23, 2023
…nic-net#15252)

* [Arista][x86_64-arista_7050_qx32] Add Components to platform.json

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* reformat

Signed-off-by: vaibhav dahiya <[email protected]>

---------

Signed-off-by: vaibhav dahiya <[email protected]>
mssonicbld pushed a commit that referenced this pull request Jun 26, 2023
…5252)

* [Arista][x86_64-arista_7050_qx32] Add Components to platform.json

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* reformat

Signed-off-by: vaibhav dahiya <[email protected]>

---------

Signed-off-by: vaibhav dahiya <[email protected]>
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
…nic-net#15252)

* [Arista][x86_64-arista_7050_qx32] Add Components to platform.json

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* fix comment

Signed-off-by: vaibhav dahiya <[email protected]>

* reformat

Signed-off-by: vaibhav dahiya <[email protected]>

---------

Signed-off-by: vaibhav dahiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants