Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:14632] Install python-redis package to docker containers #14775

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

mssonicbld
Copy link
Collaborator

No description provided.

Install python-redis package to docker containers

#### Why I did it
This this bug: sonic-net#14531
The 'flush_unused_database' is part of docker-database, and docker-database does not install python-redis package by itself. it's using redis installed by sonic-py-swsssdk.
So after remove sonic-py-swsssdk from container, this script break.

To this this bug and avoid similer bug happen again, install python-redis to docker containers which removed sonic-py-swsssdk .

#### How I did it
Install python-redis to containers.

#### How to verify it
Pass all UT.
Create new UT to cover this scenario: sonic-net/sonic-mgmt#8032

#### Description for the changelog
Improve sudo cat command for RO user.
@mssonicbld
Copy link
Collaborator Author

Original PR: #14632

@liuh-80
Copy link
Contributor

liuh-80 commented Apr 23, 2023

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 14775 in repo sonic-net/sonic-buildimage

@liuh-80
Copy link
Contributor

liuh-80 commented Apr 23, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 14775 in repo sonic-net/sonic-buildimage

@liuh-80
Copy link
Contributor

liuh-80 commented Apr 23, 2023

Following UT failed: tacacs/test_ro_user.py::test_ro_user_banned_by_sudoers_command
seems because depends sudoers fix PR cherry-pick to 202211 after this PR created: #14428

Will close and re-open to trigger buildimage and test on latest code.

@liuh-80 liuh-80 closed this Apr 23, 2023
@liuh-80 liuh-80 reopened this Apr 23, 2023
@mssonicbld mssonicbld merged commit d859a4e into sonic-net:202211 Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants