Support to add SONiC OS Version in device info #14601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
force-pushed
the
support-sonic-os-version
branch
from
e21cf24
to
5cfe0a1
Compare
lguohan
approved these changes
Apr 12, 2023
xumia
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Apr 12, 2023
…2787) What I did Support to display the SONiC OS Version in the command show version. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 How I did it The device info is in sonic-net/sonic-buildimage, see PR: sonic-net/sonic-buildimage#14601 The submodule change can be merged to sonic-buildimage, after the PR 14601 merged. How to verify it
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 12, 2023
Why I did it Support to add SONiC OS Version in device info. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 How I did it
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 12, 2023
Why I did it Support to add SONiC OS Version in device info. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 How I did it
This was referenced Apr 12, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 13, 2023
Why I did it Cherry-pick #14601, for code conflict. Support to add SONiC OS Version in device info. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 Work item tracking Microsoft ADO (number only): 17894593 How I did it How to verify it
yxieca
pushed a commit
that referenced
this pull request
Apr 18, 2023
Why I did it Support to add SONiC OS Version in device info. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 How I did it
yxieca
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Apr 19, 2023
…2787) What I did Support to display the SONiC OS Version in the command show version. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 How I did it The device info is in sonic-net/sonic-buildimage, see PR: sonic-net/sonic-buildimage#14601 The submodule change can be merged to sonic-buildimage, after the PR 14601 merged. How to verify it
StormLiangMS
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Apr 20, 2023
…2787) What I did Support to display the SONiC OS Version in the command show version. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 How I did it The device info is in sonic-net/sonic-buildimage, see PR: sonic-net/sonic-buildimage#14601 The submodule change can be merged to sonic-buildimage, after the PR 14601 merged. How to verify it
|
@xumia PR conflicts with 202211 branch |
saiarcot895
reviewed
May 20, 2023
| @@ -294,3 +294,6 @@ SONIC_SLAVE_DOCKER_DRIVER ?= vfs | |||
| # GZ_COMPRESS_PROGRAM - select pigz (a parallel implementation of gzip) to reduce a build time | |||
| # and speed up a decompression of docker images on target system | |||
| GZ_COMPRESS_PROGRAM ?= gzip | |||
|
|
|||
| # SONIC_OS_VERSION - sonic os version | |||
| SONIC_OS_VERSION ?= 11 | |||
There was a problem hiding this comment.
Does this 11 correspond to the Debian version? If so, wouldn't it be better to read from /etc/lsb_release.yml and parse the version field there, rather than having it hardcoded here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Support to add SONiC OS Version in device info.
It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)