Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set cable length of backplane ports to 1m #13279

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

zhixzhu
Copy link
Contributor

@zhixzhu zhixzhu commented Jan 5, 2023

Why I did it

backplane ports cable length need to be specified.

How I did it

separated handling for the specific port name.

How to verify it

Used "sonic-cfggen" to generate buffer config, and verified cable length of backplane ports is 1m, other ports default length.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@zhixzhu zhixzhu requested a review from lguohan as a code owner January 5, 2023 21:16
@zhixzhu
Copy link
Contributor Author

zhixzhu commented Jan 6, 2023

@lguohan There is 1 workflow awaiting approval, could you help approve it?
The failure happened when running script bgp/test_bgp_fact.py, changing the cable length of backplane ports should not have any impact on it, how to rerun this test?

@alpeshspatel
Copy link
Contributor

Hi
@yxieca @rlhui @abhishekd0

Can you please help this get merged into 202205 as well as master branch.

@zhixzhu
Copy link
Contributor Author

zhixzhu commented Jan 19, 2023

@lguohan @yxieca @rlhui @abhishekd0
All checks have passed, could you help review and merge it into 202205 and master branch?

@zhixzhu
Copy link
Contributor Author

zhixzhu commented Jan 30, 2023

@lguohan @yxieca @rlhui @abhishekd0
All checks have passed, could you help merge it into 202205 and master branch?

@zhixzhu
Copy link
Contributor Author

zhixzhu commented Feb 3, 2023

@yxieca Could you help approve and merge?

@abdosi
Copy link
Contributor

abdosi commented Feb 13, 2023

Does cherry-pick of master has conflict ?

@zhixzhu
Copy link
Contributor Author

zhixzhu commented Feb 13, 2023

The failure log is:

The following packages have unmet dependencies:
 libssl-dev : Depends: libssl1.1 (= 1.1.1n-0+deb11u4) but 1.1.1n-0+deb11u3 is to be installed
E: Unable to correct problems, you have held broken packages.

@lguohan @abdosi Could you help rerun the pipeline?

@zhixzhu
Copy link
Contributor Author

zhixzhu commented Feb 13, 2023

Does cherry-pick of master has conflict ?

Yes, the type of argument in src/sonic-config-engine/tests/test_multinpu_cfggen.py run_script is different between master and 202205 branch.

@abdosi abdosi enabled auto-merge (squash) February 13, 2023 17:55
@zhixzhu
Copy link
Contributor Author

zhixzhu commented Feb 14, 2023

@abdosi Pipeline still failed at:

The following packages have unmet dependencies:
 libssl-dev : Depends: libssl1.1 (= 1.1.1n-0+deb11u4) but 1.1.1n-0+deb11u3 is to be installed
E: Unable to correct problems, you have held broken packages.
The command '/bin/sh -c apt-get update  && apt-get -y install      net-tools               python3-pip             python-setuptools       build-essential         libssl-dev              libffi-dev              python-dev              wget                    cmake                   libqt5core5a            libqt5network5          libboost-atomic1.74.0' returned a non-zero code: 100

The failure is not related with this PR's code change, how to proceed with it? Any suggestions?

@zhixzhu
Copy link
Contributor Author

zhixzhu commented Feb 15, 2023

@abdosi I checked the recent PRs to target branch 202205, they all have the same pipeline failure on the "Build marvell_armhf", including open PRs and merged PRs, e.g. #13778

Could you help merge my PR in this case?

@zhixzhu
Copy link
Contributor Author

zhixzhu commented Feb 21, 2023

@abdosi Any suggestions on how to proceed?

@abdosi abdosi merged commit 8b5a427 into sonic-net:202205 Feb 21, 2023
@zhixzhu zhixzhu deleted the buffer-config branch February 21, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants