[install.sh] install different platform image should be blocked #13153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- What I did 1. Check platform and asic before install the image, if the platform and asic version is different with running image, the install action should be blocked. 2. This commit can block wrong installation in ONIE and CLI env. - Why I did it Install different platform-asic image will make kernel can't be reload correctly. Steps to reproduce Bug 1. Install x86 image in CLI 2. Install arm64 image in CLI 3. Install x86 image in CLI 4. reboot 5. the kernel can't be loaded, user need to insatll image by ONIE to recover it - How to verify it EX: Install build arm64 image in x86 platform, the install operation will execute fail.
|
@qiluo-msft , can you help and assign someone review this? |
qiluo-msft
reviewed
Jan 3, 2023
| onie_running_arch=`cat $machine_conf_path | grep onie_arch | sed -n "s/^onie_arch=\(.*\)$/\1/p"` | ||
| onie_running_switch_asic=`cat $machine_conf_path | grep onie_switch_asic | sed -n "s/^onie_switch_asic=\(.*\)$/\1/p"` | ||
|
|
||
| # bcm aisc is broadcom |
|
There is a similar feature #8814. Could you check if this is duplicated or partially overlapped? |
qiluo-msft
reviewed
Jan 3, 2023
| elif [ "$install_env" != "build" ]; then | ||
| echo "cannot find machine.conf" | ||
| exit 1 | ||
| fi | ||
|
|
||
| onie_running_arch=`cat $machine_conf_path | grep onie_arch | sed -n "s/^onie_arch=\(.*\)$/\1/p"` |
qiluo-msft
reviewed
Jan 3, 2023
| elif [ "$install_env" != "build" ]; then | ||
| echo "cannot find machine.conf" | ||
| exit 1 | ||
| fi | ||
|
|
||
| onie_running_arch=`cat $machine_conf_path | grep onie_arch | sed -n "s/^onie_arch=\(.*\)$/\1/p"` | ||
| onie_running_switch_asic=`cat $machine_conf_path | grep onie_switch_asic | sed -n "s/^onie_switch_asic=\(.*\)$/\1/p"` |
wen587
reviewed
Jan 5, 2023
| onie_running_switch_asic=`cat $machine_conf_path | grep onie_switch_asic | sed -n "s/^onie_switch_asic=\(.*\)$/\1/p"` | ||
|
|
||
| # bcm aisc is broadcom | ||
| if [ "$onie_running_switch_asic" = "bcm" ]; then |
There was a problem hiding this comment.
for kvm image, its onie_switch_asic is 'qemu'.
|
I prefer to keep the original design. |
|
@inspurSDN I see you closed this issue. Is your original issue still open? You may create a Github issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How I did it
Check platform and asic before install the image, if the platform and asic version is different with running image, the install action should be blocked.
This commit can block wrong installation in ONIE and CLI env.
Why I did it
Steps to reproduce Bug
How to verify it
EX: Install build arm64 image in x86 platform, the install operation will execute fail.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)