Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edgecore][device][platform] Added support to as9736-64d platform #12904

Conversation

ec-michael-shih
Copy link
Contributor

@ec-michael-shih ec-michael-shih commented Dec 1, 2022

Signed-off-by: michael_shih [email protected]

Why I did it

Need to support new platform as9736-64d

How I did it

Add device files for new platform as9736-64d
ex: sonic_platform

How to verify it

  1. sonic-cli cmd:
    show platform {fan, temperature, firmware status, syseeprom, psustatus}
  2. sfputil cmd:
    show {presence, eeprom, lpmode}
  3. Verify function by sonic-mgmt tools:
    Test file path: /tests/platform_tests/api/
    Test items: test_chassis.py, test_component.py, test_fan_drawer.py, test_psu.py, test_thermal.py, test_sfp.py

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

69920015_2536841129671228_687407595874418688_n

- Why I did it
    Need to support new platform as9736-64d

- How I did it
    Add device files for new platform as9736-64d

- How to verify it
  1. sonic-cli cmd: show platform {fan, temperature, firmware status, syseeprom, psustatus}
  2. sfputil show {presence, eeprom, lpmode}
  3. Use sonic-mgmt(/tests/platform_tests/api/{test_chassis.py, test_component.py, test_fan_drawer.py, test_psu.py, test_thermal.py, test_sfp.py})

Signed-off-by: michael_shih <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2022

This pull request introduces 12 alerts when merging 8a3823f into b774ebf - view on LGTM.com

new alerts:

  • 7 for Except block handles 'BaseException'
  • 4 for Unused local variable
  • 1 for Unreachable code

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2022

This pull request introduces 2 alerts when merging cb06ad5 into b774ebf - view on LGTM.com

new alerts:

  • 2 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2022

This pull request introduces 4 alerts when merging bd7b980 into f10f79b - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Testing equality to None

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

ec-michael-shih and others added 18 commits December 8, 2022 16:00
…sh_optoe_dev_class()) name from sfp.py(refresh_optoe_dev_class())

Signed-off-by: michael_shih <[email protected]>
…sfs size create.

Detail:
  When 400G xcvr plugin, fpga need to get support-pagable info from xcvr:
  If get info failed, do not create 256 bytes. Because this will let xcvr cannot get page1~page0xff's data.
  Enhance method is create 32,896 bytes( (1+256)*128 ) when get info failed.

Signed-off-by: michael_shih <[email protected]>
…AS9736-64D.

Detail:
  Sync with #PR:11805 about part of as9736-64d

Signed-off-by: michael_shih <[email protected]>
…ommand:[show platform ssdhealth --vendor].

Signed-off-by: michael_shih <[email protected]>
@lguohan lguohan added the device label Sep 23, 2023
…ver by FPGA

[Why to modify]:
Read/write xcvr eeprom via fpga will msleep(1) when fpga finish i2c-trigger read/write.
Sometimes it’s very fast to be finished, and do not need to wait as long as 1 ms.
Need to enhance this part.

[How to do]:
1. Referring to optoe.c, a write_timeout=25 is defined,
   because when we encounter a slower xcvr, need to retry within 25ms to ensure successful writing or reading of eeprom;
   on the other hand, xcvr can end faster.
2. Created 66 per port mutex to lock write/read eeprom, because HW confirm FPGA supports muti-access port for eeprom, instead of using one mutex-lock to access.

Signed-off-by: michael_shih <[email protected]>
Detail:
refresh_optoe_dev_class() is called by event.py via xcvrd that detected xcvr new insert, and do the port eeprom-init.
So, it did not need to run during the command of: sfputil, show interface, psuutil...etc.

Signed-off-by: michael_shih <[email protected]>
… plan.

What implement:
  XCVR rule:
  1. fan driver modify that can set fan duty-cycle to 75%
  2. When xcvr temperature > 70 ==> Increase fan duty-cycle from 50% to 75%
  3. When xcvr temperature all < 60 ==> Decrease fan duty-cycle from 75% to 50%
  3. Add syslog and console log for which criteria hit fan speed increase or decrease.

Signed-off-by: michael_shih <[email protected]>
…ge will increase slowly.

[Why to fixed]:
The root cause is get_name  64 times by every 10sec to get 64 port's interface, this will cause cpu usage keep increase slowly.

Signed-off-by: michael_shih <[email protected]>
ec-michael-shih and others added 3 commits January 23, 2024 16:26
…sync buffer to disk first.

[Why to modify]:
After doing cpu shutown and power-cycle, we'll find syslog loss shutdown message.
So need to do sync buffer to disk command first.

Signed-off-by: michael_shih <[email protected]>
…sync buffer to disk first(1).

Signed-off-by: michael_shih <[email protected]>
MuLinForest pushed a commit to MuLinForest/sonic-buildimage that referenced this pull request Aug 6, 2024
…4d_syncd_failed

[Sync PR sonic-net#15103] Provide proper configurations as its hardware design for AS9736-64D-100G based on PR:sonic-net#12904 and sonic-net#13762.
…ges by fan and psu monitor service.

Signed-off-by: michael_shih <[email protected]>
@ec-michael-shih
Copy link
Contributor Author

Collect all this PR's commits into one commit at new PR-20735, and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants