Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] use real wget for SAI_FLAGS #12665

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

kv-y
Copy link
Contributor

@kv-y kv-y commented Nov 10, 2022

Why I did it

We download libsaibcm.deb every time when we use make to build.
That's because we use build hook but not real wget to get hash for SAI_FLAGS.
As a result we also call curl for libsaibcm.deb inside of function download_packages.

How I did it

Add SKIP_BUILD_HOOK=y to use real wget instead of build hook.

How to verify it

I redirected all requests to proxy to log them (1st column is timing).

Without fix (curl, curl , wget):

1668034736.348 0 CONNECT sonicstorage.blob.core.windows.net:443
1668034831.997 40064209 GET https://sonicstorage.blob.core.windows.net/public/sai/bcmsai/REL_7.0/7.1.17.4/libsaibcm_7.1.17.4_amd64.deb
1668034832.601 0 CONNECT sonicstorage.blob.core.windows.net:443
1668034833.212 113911 GET https://sonicstorage.blob.core.windows.net/public/sai/bcmsai/REL_7.0/7.1.17.4/libsaibcm-dev_7.1.17.4_amd64.deb
1668034833.831 0 CONNECT sonicstorage.blob.core.windows.net:443
1668034834.030 549 HEAD https://sonicstorage.blob.core.windows.net/public/sai/bcmsai/REL_7.0/7.1.17.4/libsaibcm_7.1.17.4_amd64.deb
1668034834.235 547 HEAD https://sonicstorage.blob.core.windows.net/public/sai/bcmsai/REL_7.0/7.1.17.4/libsaibcm-dev_7.1.17.4_amd64.deb

Fixed version (only wget):

1668034973.199 0 CONNECT sonicstorage.blob.core.windows.net:443
1668034973.339 549 HEAD https://sonicstorage.blob.core.windows.net/public/sai/bcmsai/REL_7.0/7.1.17.4/libsaibcm_7.1.17.4_amd64.deb
1668034973.501 547 HEAD https://sonicstorage.blob.core.windows.net/public/sai/bcmsai/REL_7.0/7.1.17.4/libsaibcm-dev_7.1.17.4_amd64.deb

Signed-off-by: Konstantin Vasin [email protected]

Signed-off-by: Konstantin Vasin <[email protected]>
@kv-y
Copy link
Contributor Author

kv-y commented Nov 10, 2022

@Kalimuthu-Velappan
Probably you can also review this PR.
Originally you added this solution with wget in #5651
But now it doesn't work as expected cause we are using a build hook instead of real wget.

@Kalimuthu-Velappan
Copy link
Contributor

@Kalimuthu-Velappan Probably you can also review this PR. Originally you added this solution with wget in #5651 But now it doesn't work as expected cause we are using a build hook instead of real wget.

The changes look good.

@kv-y
Copy link
Contributor Author

kv-y commented Nov 18, 2022

@lguohan
Could you please review this PR?

@kv-y
Copy link
Contributor Author

kv-y commented Nov 24, 2022

@xumia

Maybe you can help to review and merge this fix?
I afraid that it will be lost.

Without this fix every time you run make you download libsaibcm (40Mb) from sonicstorage.
E.g. you do make some-pkg-clean and download libsaibcm.
After that you do make some-pkg and libsaibcm is downloaded again.
You do make list and wait again.

As a result every time you lose from some seconds to some minutes.

@lguohan lguohan merged commit dfc73fc into sonic-net:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants