-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed nokia platform m0 asic mismatch #12148
Conversation
changed the platform device name under nokia directory; we now need to specify marvell armhf/arm64 to provide more accurate platform identity. otherwise onie discovery won't recognize the asic being installed.
@yaqiangz for awareness. Some of tests were skipped by checking asic_type == 'marvell', now we'd better update these condition to 'marvell' in asic_type |
@hehuang-nokia which release branch will be impacted by this issue? Do you want to this fix backport to 202012 and 202205? |
I tested latest 202205 which also has the issue but have not seen the problem in 202012 yet. tests ongoing. will update and mark 202012 if problem found. |
@hehuang-nokia Current PR issue is not related to PR 6401. We raise PR 6401 was due to we are skipping some sonic-mgmt test cases by checking the asic_type and we need to update them accordingly. For your PR, the build failure seems like caused by transient network issue. I will rerun these build pipelines |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
) What is the motivation for this PR? Asic of Nokia-7215 was replaced by sonic-net/sonic-buildimage#12148, which will cause skip failure about Nokia-7215 How did you do it? Modify skip conditions.
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/easycla |
|
@hehuang-nokia could you sign CLA per above instruction? |
Thanks for the reminder and instructions. It has been signed. |
| * cb707b7 fixed nokia platform m0 asic mismatch (fixed nokia platform m0 asic mismatch #12148) | * c75dfe8 [build] Fix dpkg front lock issue with apt-get ([build] Fix dpkg front lock issue caused by apt-get install #12332) | * 247bd78 [action] Fix PR pre-cherry-pick action wrong author issue. ([action] Fix PR pre-cherry-pick action wrong author issue. #12339) | * fc99265 [Nokia] Update the nokia platform submodule for Nokia-IXR7250E platform ([Nokia] Update the nokia platform submodule for Nokia-IXR7250E platform #12305) | * 9d37b63 [Nokia] Update Nokia platform IXR7250E device data ([Nokia] Update Nokia platform IXR7250E device data #11611) | * 304c6c8 [BFN] Reworked BFN platform thermals plugin ([BFN] Reworked BFN platform thermals plugin #11723) | * df93a1b [Build][Bug] Fix apt-get remove version not lock issue ([Build][Bug] Fix apt-get remove version not locked issue #12193) | * 9b2b8e3 Add gearbox taps to vs gearbox_config.json (Add gearbox taps to vs gearbox_config.json #11480)
) What is the motivation for this PR? Asic of Nokia-7215 was replaced by sonic-net/sonic-buildimage#12148, which will cause skip failure about Nokia-7215 How did you do it? Modify skip conditions.
…nic-net#6401) What is the motivation for this PR? Asic of Nokia-7215 was replaced by sonic-net/sonic-buildimage#12148, which will cause skip failure about Nokia-7215 How did you do it? Modify skip conditions.
@yxieca Could you help back port this fix to 202205? |
changed the platform device name under nokia directory; we now need to specify marvell armhf/arm64 to provide more accurate platform identity. otherwise onie discovery won't recognize the asic being installed. Why I did it when we load images using onie discovery, the process was failing because of marvell ASIC mismatch How I did it replace the platform asic with marvell-armhf under 7215 How to verify it load a new image using http server and verify that the image can be loaded successfully
…nic-net#6401) What is the motivation for this PR? Asic of Nokia-7215 was replaced by sonic-net/sonic-buildimage#12148, which will cause skip failure about Nokia-7215 How did you do it? Modify skip conditions.
changed the platform device name under nokia directory; we now need to specify marvell armhf/arm64 to provide more accurate platform identity. otherwise onie discovery won't recognize the asic being installed.
Why I did it
when we load images using onie discovery, the process was failing because of marvell ASIC mismatch
How I did it
replace the platform asic with marvell-armhf under 7215
How to verify it
load a new image using http server and verify that the image can be loaded successfully
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)