Added Support to runtime render bgp and teamd feature state and lldp has_asic_scope flag #11796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (sonic-net#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (sonic-net#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (sonic-net#35) Signed-off-by: Abhishek Dosi <[email protected]>
has_asic_scope flag. Signed-off-by: Abhishek Dosi <[email protected]>
This was referenced Aug 19, 2022
Signed-off-by: Abhishek Dosi <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
|
@mlok-nokia : Can you please approve this. |
|
@arlakshm can you please review this. |
judyjoseph
reviewed
Nov 15, 2022
judyjoseph
reviewed
Nov 15, 2022
| @@ -61,7 +61,11 @@ | |||
| "state": "{{state}}", | |||
| "has_timer" : {{has_timer | lower()}}, | |||
| "has_global_scope": {% if feature + '.service' in installer_services.split(' ') %}true{% else %}false{% endif %}, | |||
| {%- if feature in ["lldp"] %} | |||
| "has_per_asic_scope": {% raw %}"{% if not DEVICE_RUNTIME_METADATA['ETHERNET_PORTS_PRESENT'] or ('CHASSIS_METADATA' in DEVICE_RUNTIME_METADATA and DEVICE_RUNTIME_METADATA['CHASSIS_METADATA']['module_type'] in ['supervisor']) %}False{% else %}True{% endif %}"{% endraw %}, | |||
| {%- else %} | |||
| "has_per_asic_scope": {% if feature + '@.service' in installer_services.split(' ') %}true{% else %}false{% endif %}, | |||
There was a problem hiding this comment.
has_per_asic_scope is changed from boolean_type to string, should we change here too ?
There was a problem hiding this comment.
@judyjoseph : thanks for the comment and catching this. Updated.
Signed-off-by: Abhishek Dosi <[email protected]>
judyjoseph
approved these changes
Nov 16, 2022
|
@abdosi this PR cannot be cherry-picked cleanly. Can you raise separate PR for 202205? |
abdosi
added a commit
to abdosi/sonic-buildimage
that referenced
this pull request
Nov 28, 2022
…has_asic_scope flag (sonic-net#11796) Added Support to runtime render bgp and teamd feature `state` and lldp `has_asic_scope` flag Needed for SONiC on chassis. Signed-off-by: Abhishek Dosi <[email protected]> Co-authored-by: mlok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added Support to runtime render bgp and teamd feature
stateand lldphas_asic_scopeflagHow I did:
Define new runtime metadata
dictas define in #11795 which is used for rendering by hostcfgd.Also in
swss.shonly add teamd as Dependent service if Ethernet ports are present on the device.Same approach can be used for other docker/services as needed.
Hostcfgd modication: sonic-net/sonic-host-services#14
Order of PR merge will be:
#11795
sonic-net/sonic-host-services#14 and Submodule Update of same.
Finally this PR will be merged.
Why I did:
Not to create dockers which are not needed.
How I Verify:
Manual Verification.