[make] Introducing build option SOURCE_FOLDER #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When KEEP_SLAVE_ON=yes and SOURCE_FOLDER is defined, the path pointed by SOURCE_FOLDER will be mounted in the build slave docker at /var/src. This option allows user to mount an extra path into the build slave when the slave is left running. Usually when user need to build extra stuff in SOURCE_FOLDER.
lguohan
approved these changes
Nov 16, 2017
|
When checking sonic jenkins, the link looks broken. Would you please fix the link? |
|
Which link? |
|
Once a commit is merged, I think jenkins is up and running. I just clicked on "view details" above, and clicked jenkins job which redirects to https://sonic-jenkins.westus2.cloudapp.azure.com/job/broadcom/job/buildimage-brcm-all-pr/1267/ Basically, https://sonic-jenkins.westus.cloudapp.azure.com/ is down. |
3 tasks
3 tasks
lguohan
pushed a commit
that referenced
this pull request
Nov 6, 2020
Add a switch to route_check to control whether write log to syslog (#1215) [consutil] Store console port state in STATE_DB (#1208) [sfputil] Display 'N/A' for non-SFP ports (#1078) Show FG_NHG CLI Commands Added (#1056) [show] remove 'device2interface_dict' in show interface neighbor expected (#1188) Add license file, remove third-party licenses file (#1192) [fwutil]: Set min log priority to INFO. (#1191) [CLI][show][platform] Added ASIC count in the output. (#1185) fdbshow and nbrshow use SonicV2Connector with decode_responses=True, and remove all the decode() (#1187) Remove stdeb.cfg; no longer used now that we build as wheel (#1182) [counterpoll] Disable Counter Poll When Entering Fast Reboot (#1174) Fixes the issue with show interface counters and for pfc and queue counters. (#1180) [config/show] Add CLI support for proxy arp (#1168) [consutil] Add brief option to show line command (#1176) Modify fast-reboot script to use BGP service script to stop bgp service (#1177) [config/console] Support update console configuration related commands (#1166) [consutil] Fix issue where the show line command crash if no ttyUSB exists (#1173) [watermarkstat] Add unit tests for watermarkstat show commands (#1157) Fix exception for ipaddress in python2 (#1164) [celestica] consutil to support customize tty device name (#1155) Signed-off-by: Danny Allen <[email protected]>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Add a switch to route_check to control whether write log to syslog (sonic-net#1215) [consutil] Store console port state in STATE_DB (sonic-net#1208) [sfputil] Display 'N/A' for non-SFP ports (sonic-net#1078) Show FG_NHG CLI Commands Added (sonic-net#1056) [show] remove 'device2interface_dict' in show interface neighbor expected (sonic-net#1188) Add license file, remove third-party licenses file (sonic-net#1192) [fwutil]: Set min log priority to INFO. (sonic-net#1191) [CLI][show][platform] Added ASIC count in the output. (sonic-net#1185) fdbshow and nbrshow use SonicV2Connector with decode_responses=True, and remove all the decode() (sonic-net#1187) Remove stdeb.cfg; no longer used now that we build as wheel (sonic-net#1182) [counterpoll] Disable Counter Poll When Entering Fast Reboot (sonic-net#1174) Fixes the issue with show interface counters and for pfc and queue counters. (sonic-net#1180) [config/show] Add CLI support for proxy arp (sonic-net#1168) [consutil] Add brief option to show line command (sonic-net#1176) Modify fast-reboot script to use BGP service script to stop bgp service (sonic-net#1177) [config/console] Support update console configuration related commands (sonic-net#1166) [consutil] Fix issue where the show line command crash if no ttyUSB exists (sonic-net#1173) [watermarkstat] Add unit tests for watermarkstat show commands (sonic-net#1157) Fix exception for ipaddress in python2 (sonic-net#1164) [celestica] consutil to support customize tty device name (sonic-net#1155) Signed-off-by: Danny Allen <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
…1155) * Update lib.py * Keep the code format align see add spaces for special symbols * remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When KEEP_SLAVE_ON=yes and SOURCE_FOLDER is defined, the path pointed
by SOURCE_FOLDER will be mounted in the build slave docker at /var/src.
This option allows user to mount an extra path into the build slave
when the slave is left running. Usually when user need to build extra
stuff in SOURCE_FOLDER.
- How to verify it
Build with KEEP_SLAVE_ON=yes, verified that the left running build slave doesn't have /var/src mounted.
Build with KEEP_SLAVE_ON=yes SOURCE_FOLDER="a valid path", verified that the has been mounted in the left running build slave at /var/src and it is accessible.
Build with KEEP_SLAVE_ON=yes SOURCE_FOLDER="an invalid path", verified that /var/src is visible in left running build slave but not accessible.