[sonic-feature.yang] fix check_up_status field type #10986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
6 tasks
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jun 2, 2022
| type boolean; | ||
| default false; | ||
| type stypes:boolean_type; | ||
| default "false"; |
There was a problem hiding this comment.
@qiluo-msft Without this fix sonic-utilities submodule update is blocked. There were no UT when this field was added. I suggest to take this fix to unblock submodule update and the owner of new feature adds UT.
There was a problem hiding this comment.
@wen587 for awareness of blocking issue of sonic-utilities submodule update
ganglyu
approved these changes
Jun 2, 2022
This was referenced Jun 10, 2022
Merged
qiluo-msft
approved these changes
Jun 10, 2022
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 tasks
|
@stepanblyschak please chck if this is needed for 202205 and if so update PR desciption/label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak [email protected]
Why I did it
An issue is encountered when a value "False" is written for a feature in "check_up_status" field, which does not pass YANG validation.
How I did it
We usually use stypes::boolean_type for such fields, even in this YANG model. This custom type, supports "False" value.
How to verify it
Write "False" in "check_up_status" field and see if YANG validation passes.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)