-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cherry-pick] [202012] Update qos config to clear queues for bounced back traffic #10608
Conversation
Signed-off-by: bingwang <[email protected]>
is there enable and disable flag? |
Now that there are 4 lossless queues on the ports connecting T1 and dual ToR on the egress side while 2 lossless queues on the rest ports, is there a logic to update the |
Yes, there will be a flag to turn on/off the feature. Please review HLD sonic-net/SONiC#982 |
I don't think the change will impact T2 or above. There are 4 lossless queues in ports between T1 and ToR. |
Typo. it should be T1 and ToR. I updated the original comment |
Thanks. We already have a PR to update |
Signed-off-by: bingwang <[email protected]>
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Signed-off-by: bingwang <[email protected]>
Signed-off-by: bingwang <[email protected]>
Signed-off-by: bingwang <[email protected]>
@bingwang-ms can you resolve the conflict and retrigger the build? thanks. |
Thanks. All fixed. |
Please hold on merging this PR until the |
Signed-off-by: bingwang <[email protected]>
Signed-off-by: bingwang <[email protected]>
Signed-off-by: bingwang <[email protected]>
Signed-off-by: bingwang <[email protected]>
This PR is to cherry-pick #10176 and #10565 to
202012
branch after resolving conflicts.Signed-off-by: bingwang [email protected]
Why I did it
This PR is to redefine
DSCP_TO_DC_MAP
,TC_TO_QUEUE_MAP
andTC_TO_PRIORITY_GROUP_MAP
table to clear queue 2 and queue 6 for bounced back traffic.To support the extra lossless queue 2 and 6, the table
pfc_enable
,pfcwd_sw_enable
andSCHEDULER
are also updated in the template.HLD sonic-net/SONiC#950
SKU includes
Changed table:
To map DSCP33->TC 2 as we need to conserve DSCP 33 for bounced back traffic.
The tunnel level map will map TC 2 -> DSCP 33
As we mapped DSCP33->TC2 on ToR router, we need to remap TC2 to a lossy queue
How I did it
Define a macro for SKUs that requires remapping.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Update qos config to clear queues for bounced back traffic.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)