[logrotate.conf]: Truncate log files #1027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new file we have a problem that the handle to an original log file is no longer valid. It can be bad for those programs that write to log file or read from it. So log file now is truncated instead.
jleveque
reviewed
Oct 10, 2017
|
My opinion is that all log files need to be truncated. But if you have some objections, it's up to discussion. |
nikos-github
approved these changes
Nov 17, 2017
|
Retest this please. |
|
in the commit message, it mentions "we have a problem". which log file has this problem exactly? for syslog, we are doing rsyslog reload after rotate so it should not be a problem. |
jleveque
added a commit
that referenced
this pull request
Aug 9, 2020
* src/sonic-utilities 9700e45...621aad0 (9): > [Python] Migrate applications/scripts to import sonic-py-common package (#1008) > [config qos] QoS and Buffer config genration for multi ASIC platforms (#978) > [cli]: pass db connector as click context (#1029) > [PDDF] Make utilities compatible to platform API 2.0, in accordance with pddf_2.0 (#940) > [tests] Add unit tests for 'show platform ...' commands (#1021) > Add secure fast/warm-reboot support for Aboot (#994) > [sonic-installer] Create Envvars File for Incoming Image (#1011) > [config load]: do not stop/reset/reload service if it is disabled (#1028) > [tests]: move feature_test.py into tests folder (#1027)
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* src/sonic-utilities 9700e45...621aad0 (9): > [Python] Migrate applications/scripts to import sonic-py-common package (sonic-net#1008) > [config qos] QoS and Buffer config genration for multi ASIC platforms (sonic-net#978) > [cli]: pass db connector as click context (sonic-net#1029) > [PDDF] Make utilities compatible to platform API 2.0, in accordance with pddf_2.0 (sonic-net#940) > [tests] Add unit tests for 'show platform ...' commands (sonic-net#1021) > Add secure fast/warm-reboot support for Aboot (sonic-net#994) > [sonic-installer] Create Envvars File for Incoming Image (sonic-net#1011) > [config load]: do not stop/reset/reload service if it is disabled (sonic-net#1028) > [tests]: move feature_test.py into tests folder (sonic-net#1027)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
Signed-off-by: Guohan Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new file we have a problem
that the handle to an original log file is no longer valid.
It can be bad for those programs that write to log file
or read from it. So log file now is truncated instead.