-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag/commit hash is not respected in new image builds #6445
Comments
When building the sonic-slave-buster docker container, the node.js package is installed to meet the requirements of the Azure DevOPs pipleline build. Recently this install of node.js has been failing as described within Sonic issue sonic-net#6445. This commit fixes that build break by upgrading the sonic-slave-buster build to install version 14.x of node.js which is the current LTS version for buster.
I do not think this issue is related to #6469 |
It looks like the issue is coming from ./platform/broadcom/sonic-platform-modules-dell/z9332f/build/lib.linux-x86_64-2.7/sonic_platform/ipmihelper.py. This file is overridden by ./platform/broadcom/sonic-platform-modules-dell/common/ipmihelper.py in platform/broadcom/sonic-platform-modules-dell/debian/rules, which causes the workspace to become dirty. Following up with Dell. |
Fixes #6445 Because the ipmihelper.py script in the 9332 folder is slightly different than the common one (due to LGTM fixes), when the common one gets copied during build time it causes the workspace/build to become dirty. Signed-off-by: Danny Allen <[email protected]>
Fixes #6445 Because the ipmihelper.py script in the 9332 folder is slightly different than the common one (due to LGTM fixes), when the common one gets copied during build time it causes the workspace/build to become dirty. Signed-off-by: Danny Allen <[email protected]>
Description
Recent 202012 builds from Jenkins are coming out like this:
Steps to reproduce the issue:
show ver
on a DUTDescribe the results you received:
Image says "dirty" and has a time stamp like so:
Describe the results you expected:
Image version should just have the tag/commit hash that it was built off of, since there are no outstanding changes when we build on Jenkins.
Additional information you deem important (e.g. issue happens only occasionally):
If you look at the output in the build logs, it looks like the initial container/buster container has the correct image version, but subsequent ones do not.
The text was updated successfully, but these errors were encountered: