-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing validation for "config interface ip add" command in case of assigning an ip-address on a trunk port. #6426
Labels
Comments
Moved from sonic-net/sonic-utilities#807 and edited. |
Though this is invalid config, CLI check can be enhanced to return warning for such scenario. |
anshuv-mfst
added
Help Wanted 🆘
Triaged
this issue has been triaged
Enhancement ➕
labels
Jan 20, 2021
liat-grozovik
pushed a commit
to sonic-net/sonic-utilities
that referenced
this issue
Jan 25, 2021
…1374) **- What I did** Fixed bug sonic-net/sonic-buildimage#6426 Added a validation in config/main.py to prevent configuring IP interface on a port which is a member of VLAN **- How I did it** Change config/main.py **- How to verify it** Add interface as member in vlan Try to configure IP address on same interface **- Previous command output (if the output of a command-line utility has changed)** Success in the above scenario. **- New command output (if the output of a command-line utility has changed)** prevent configuration: "Interface Ethernet0 is a member of vlan Aborting!"
Bug has been fixed.
|
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this issue
Mar 2, 2021
…onic-net#1374) **- What I did** Fixed bug sonic-net/sonic-buildimage#6426 Added a validation in config/main.py to prevent configuring IP interface on a port which is a member of VLAN **- How I did it** Change config/main.py **- How to verify it** Add interface as member in vlan Try to configure IP address on same interface **- Previous command output (if the output of a command-line utility has changed)** Success in the above scenario. **- New command output (if the output of a command-line utility has changed)** prevent configuration: "Interface Ethernet0 is a member of vlan Aborting!"
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this issue
Aug 3, 2023
…(#1374) **- What I did** Fixed bug sonic-net/sonic-buildimage#6426 Added a validation in config/main.py to prevent configuring IP interface on a port which is a member of VLAN **- How I did it** Change config/main.py **- How to verify it** Add interface as member in vlan Try to configure IP address on same interface **- Previous command output (if the output of a command-line utility has changed)** Success in the above scenario. **- New command output (if the output of a command-line utility has changed)** prevent configuration: "Interface Ethernet0 is a member of vlan Aborting!"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There should be verification for config interface ip add command in case of assigning an ip-address on a trunk port.
Steps to reproduce the issue
Add a vlan
Add interfaces to vlan
Assign IP addresses on trunks ports
Describe the results you received
Having assigned an ip-address on a trunk port neither L2 not L3 traffic (with and without 802.1Q header) can't flow via such port.
L2 traffic is not being processed because it's a L3 port (dst mac differs from this port's mac)
But this L3 port treats all untagged traffic as tagged (see this bug [https://github.com//issues/3943])
Describe the results you expected
There are two options:
Output of show version
The text was updated successfully, but these errors were encountered: