Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dualtor_route_check failure observed in fast-reboot #17200

Closed
lolyu opened this issue Nov 16, 2023 · 2 comments · Fixed by sonic-net/sonic-utilities#3244
Closed

dualtor_route_check failure observed in fast-reboot #17200

lolyu opened this issue Nov 16, 2023 · 2 comments · Fixed by sonic-net/sonic-utilities#3244
Assignees
@lolyu
Labels
Bug 🐛 Issue for 202305 MSFT Triaged this issue has been triaged

Comments

@lolyu
Copy link
Contributor

lolyu commented Nov 16, 2023

Description

Steps to reproduce the issue:

  1. run fast-reboot
  2. run dualtor_neighbor_check

Describe the results you received:

root@lab-dev-acs-11:~# dualtor_neighbor_check.py -l DEBUG
Running command: sudo redis-cli EVALSHA c53fd5eaad68be1e66a2fe80cd20a9cb18c91259 0
Command output: b'NOSCRIPT No matching script. Please use EVAL.\n\n'
Command return code: 0
Traceback (most recent call last):
  File "/usr/local/bin/dualtor_neighbor_check.py", line 490, in <module>
    neighbors, mux_states, hw_mux_states, asic_fdb, asic_route_table, asic_neigh_table = read_tables_from_db(appl_db)
  File "/usr/local/bin/dualtor_neighbor_check.py", line 316, in read_tables_from_db
    tables = json.loads(result)
  File "/usr/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.9/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):
@lolyu lolyu added the Bug 🐛 label Nov 16, 2023
@lolyu lolyu self-assigned this Nov 16, 2023
@arlakshm arlakshm added Triaged this issue has been triaged MSFT labels Nov 22, 2023
@ZhaohuiS
Copy link
Contributor

ZhaohuiS commented Mar 5, 2024

@lolyu which image does it happen on?

@lolyu
Copy link
Contributor Author

lolyu commented Mar 22, 2024 •
edited
Loading

@lolyu which image does it happen on?

@ZhaohuiS 202305 and after.

@lolyu lolyu mentioned this issue Mar 26, 2024
Merged
lolyu added a commit to sonic-net/sonic-utilities that referenced this issue Apr 1, 2024
@lolyu
[dualtor_neighbor_check] Fix the script not exists issue (#3244)
52e9117 
What I did
Fix sonic-net/sonic-buildimage#17200

Microsoft ADO (number only): 27317600
Upon advanced-reboot, the Lua script is flushed, so the EVALSHA command
might suffer from the script not-existed issue. Let's check if the
script exists before calling EVALSHA.

Signed-off-by: Longxiang Lyu [email protected]

How I did it
As the above.

How to verify it
UT and verify on dualtor testbed.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this issue Apr 1, 2024
@lolyu @mssonicbld
[dualtor_neighbor_check] Fix the script not exists issue (sonic-net#3244
5a8c947 
)

What I did
Fix sonic-net/sonic-buildimage#17200

Microsoft ADO (number only): 27317600
Upon advanced-reboot, the Lua script is flushed, so the EVALSHA command
might suffer from the script not-existed issue. Let's check if the
script exists before calling EVALSHA.

Signed-off-by: Longxiang Lyu [email protected]

How I did it
As the above.

How to verify it
UT and verify on dualtor testbed.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
@mssonicbld mssonicbld mentioned this issue Apr 1, 2024
Merged
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this issue Apr 1, 2024
@lolyu @mssonicbld
[dualtor_neighbor_check] Fix the script not exists issue (sonic-net#3244
00807b1 
)

What I did
Fix sonic-net/sonic-buildimage#17200

Microsoft ADO (number only): 27317600
Upon advanced-reboot, the Lua script is flushed, so the EVALSHA command
might suffer from the script not-existed issue. Let's check if the
script exists before calling EVALSHA.

Signed-off-by: Longxiang Lyu [email protected]

How I did it
As the above.

How to verify it
UT and verify on dualtor testbed.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
@mssonicbld mssonicbld mentioned this issue Apr 1, 2024
Merged
mssonicbld pushed a commit to sonic-net/sonic-utilities that referenced this issue Apr 1, 2024
@lolyu @mssonicbld
[dualtor_neighbor_check] Fix the script not exists issue (#3244)
d6eec0f 
What I did
Fix sonic-net/sonic-buildimage#17200

Microsoft ADO (number only): 27317600
Upon advanced-reboot, the Lua script is flushed, so the EVALSHA command
might suffer from the script not-existed issue. Let's check if the
script exists before calling EVALSHA.

Signed-off-by: Longxiang Lyu [email protected]

How I did it
As the above.

How to verify it
UT and verify on dualtor testbed.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
mssonicbld pushed a commit to sonic-net/sonic-utilities that referenced this issue Apr 1, 2024
@lolyu @mssonicbld
[dualtor_neighbor_check] Fix the script not exists issue (#3244)
a056e9d 
What I did
Fix sonic-net/sonic-buildimage#17200

Microsoft ADO (number only): 27317600
Upon advanced-reboot, the Lua script is flushed, so the EVALSHA command
might suffer from the script not-existed issue. Let's check if the
script exists before calling EVALSHA.

Signed-off-by: Longxiang Lyu [email protected]

How I did it
As the above.

How to verify it
UT and verify on dualtor testbed.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this issue Apr 2, 2024
@lolyu @arfeigin
[dualtor_neighbor_check] Fix the script not exists issue (sonic-net#3244
05e2b64 
)

What I did
Fix sonic-net/sonic-buildimage#17200

Microsoft ADO (number only): 27317600
Upon advanced-reboot, the Lua script is flushed, so the EVALSHA command
might suffer from the script not-existed issue. Let's check if the
script exists before calling EVALSHA.

Signed-off-by: Longxiang Lyu [email protected]

How I did it
As the above.

How to verify it
UT and verify on dualtor testbed.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolyu lolyu

Labels
Bug 🐛 Issue for 202305 MSFT Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dualtor_neighbor_check] Fix the script not exists issue lolyu/sonic-utilities
3 participants
@lolyu @arlakshm @ZhaohuiS