Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SONIC cli commands for QoS/MMU configuration/stats for multi-asic #15148

Closed
vmittal-msft opened this issue May 19, 2023 · 10 comments
Closed
Assignees
Labels

Comments

@vmittal-msft
Copy link
Contributor

vmittal-msft commented May 19, 2023

Description

Need to enhance SONIC cli commands for QoS/MMU configuration/stats for chassis. Some of the commands support '-n asic0/asic1' but some don't.

mmuconfig -l (show buffer)
ecnconfig -l (show ecn)
show buffer_pool watermark/persistent-watermark
Show headroom-pool watermark/persistent-watermark
show pfc asymmetric/counters/priority
show pfcwd stats/config
Show priority-group drop/persistent-watermark/watermark
Show queue counters/persistent-watermark/watermark

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

QoS-MMU commands output.txt

Additional information you deem important (e.g. issue happens only occasionally):

@vmittal-msft vmittal-msft added the Chassis 🤖 Modular chassis support label May 19, 2023
@arlakshm
Copy link
Contributor

This is feature ask to support all the qos commands natively for multi asic linecards.

@kenneth-arista
Copy link
Contributor

@vmittal-msft Arista is working on this. Please assign to me.

@vmittal-msft
Copy link
Contributor Author

@kenneth-arista @bktsim-arista please update PRs in description section for better tracking ? Also, are we expecting more PRs for pfc and pfcwd changes ?

@rdjeric-arista
Copy link

@vmittal-msft

sonic-net/sonic-utilities#3057
Places the PFC commands in a class (no namespace changes in this PR; such changes will come in a later PR)

sonic-net/sonic-utilities#3058
show priority-group drop counters

sonic-net/sonic-utilities#3059
dropstat -c show
show dropcounters counts

sonic-net/sonic-utilities#3060
show buffer_pool watermark/persistent-watermark
show headroom-pool watermark/persistent-watermark
show priority-group persistent-watermark/watermark
show queue persistent-watermark/watermark

sonic-net/sonic-utilities#3061
mmuconfig -l

sonic-net/sonic-utilities#3062
ecnconfig -l
config ecn
show ecn

arlakshm pushed a commit to sonic-net/sonic-utilities that referenced this issue May 31, 2024
What I did
This change puts contents originally in pfc/main.py into a class, to support the usage of the multi-asic helper in a future change. This change is required, as multi-asic helper being used expects members self.config_db and self.db to exist when a function with the decorator run_on_multi_asic is called. The multi-asic class helper will be used to add multi-asic support to pfc commands in a following pull request.

This is a part of the set of changes being pushed for sonic-net/sonic-buildimage#15148

How I did it
Moved contents of PFC commands into a class. There are no functional changes.

Co-authored-by: rdjeric <[email protected]>
Co-authored-by: Kenneth Cheung <[email protected]>
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this issue Jun 16, 2024
What I did
This change puts contents originally in pfc/main.py into a class, to support the usage of the multi-asic helper in a future change. This change is required, as multi-asic helper being used expects members self.config_db and self.db to exist when a function with the decorator run_on_multi_asic is called. The multi-asic class helper will be used to add multi-asic support to pfc commands in a following pull request.

This is a part of the set of changes being pushed for sonic-net/sonic-buildimage#15148

How I did it
Moved contents of PFC commands into a class. There are no functional changes.

Co-authored-by: rdjeric <[email protected]>
Co-authored-by: Kenneth Cheung <[email protected]>
@kenneth-arista
Copy link
Contributor

@vmittal-msft with sonic-net/sonic-utilities#3060 merging recently, I believe this issue is now complete. Please confirm and then close this issue.

@arista-hpandya
Copy link

Queuestat (sonic-net/sonic-utilities#3554) is the last PR required to close this issue.

For future maintenance here is a checklist I have prepared to make sure we are following the best practices when adding multi-asic support to SONiC CLI. Sharing it here for the benefit of the community: https://gist.github.com/arista-hpandya/716e955a4b896d6e6343bf19516804f2

@vmittal-msft
Copy link
Contributor Author

Thanks for help @arista-hpandya @bktsim-arista @rdjeric-arista @kenneth-arista and arista team. Please double check one more time to make sure we are not missing any request. If not, please go ahead and close.

@arista-hpandya
Copy link

arista-hpandya commented Oct 1, 2024

Hi @vmittal-msft, yes I have cross-checked that we can close the issue.

PS: I don't have the permission to close the issue so requesting a moderator to close this.

@kenneth-arista
Copy link
Contributor

Hi @vmittal-msft, yes I have cross-checked that we can close the issue.

PS: I don't have the permission to close the issue so requesting a moderator to close this.

Echoing @arista-hpandya's comment, @vmittal-msft please close this issue as complete at your convenience.

@vmittal-msft
Copy link
Contributor Author

Thanks Arista team for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

6 participants