Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRR] Submodule was not updated to 8.2 #11484

Closed
DavidZagury opened this issue Jul 19, 2022 · 3 comments
Closed

[FRR] Submodule was not updated to 8.2 #11484

DavidZagury opened this issue Jul 19, 2022 · 3 comments
Assignees
@abdosi
Labels
BRCM Issue for 202205 Triaged this issue has been triaged

Comments

@DavidZagury
Copy link
Contributor

DavidZagury commented Jul 19, 2022 •
edited
Loading

Description

Although SONiC has upgraded FRR to 8.2 the FRR submodule in our code base, on both master and 202205 branches, is still pointing to the same hash c69608a which is part of the FRR branch origin/frr/7.5.

It seems that the PR that updated the FRR version ( #10691 ) has updated the .gitmodules file to the new FRR branch and the makefiles to reflect the new FRR version, but it kept the FRR submodule pointing to the 7.5 branch – as you can see here: src/sonic-frr

Describe the results you received:

FRR Submodule is pointing to hash sonic-net/sonic-frr@c69608a which is part of the FRR branch origin/frr/7.5.

Describe the results you expected:

FRR Submodule should point to hash sonic-net/sonic-frr@79188bf which is part of the FRR branch origin/frr/8.2.
@hasan-brcm hasan-brcm mentioned this issue Jul 21, 2022
Merged
7 tasks
@liat-grozovik
Copy link
Collaborator

@hasan-brcm could you please self signin this issue on you?

@zhangyanzhao zhangyanzhao added Triaged this issue has been triaged BRCM labels Aug 3, 2022
@zhangyanzhao
Copy link
Collaborator

Fix is provided.

@yxieca
Copy link
Contributor

yxieca commented Aug 17, 2022

@abdosi please review.

prsunny pushed a commit that referenced this issue Sep 10, 2022
@hasan-brcm
Update submodule to FRR 8.2.2 (#11502)
c53972b 
*The sonic-frr was upgraded to FRR 8.2.2 as part of PR #10691. However, sonic-frr/frr submodule was still referring to previous 7.5 version. Update the sonic-frr/frr submodule to 8.2.2 commit id. Fixes issue #11484.
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this issue Sep 14, 2022
@hasan-brcm @dgsudharsan
Update submodule to FRR 8.2.2 (sonic-net#11502)
1b5c07d 
*The sonic-frr was upgraded to FRR 8.2.2 as part of PR sonic-net#10691. However, sonic-frr/frr submodule was still referring to previous 7.5 version. Update the sonic-frr/frr submodule to 8.2.2 commit id. Fixes issue sonic-net#11484.
@dgsudharsan dgsudharsan mentioned this issue Sep 14, 2022
Merged
7 tasks
prsunny pushed a commit that referenced this issue Sep 15, 2022
@dgsudharsan @hasan-brcm
Update submodule to FRR 8.2.2 (#11502) (#12074)
79ca976 
*The sonic-frr was upgraded to FRR 8.2.2 as part of PR #10691. However, sonic-frr/frr submodule was still referring to previous 7.5 version. Update the sonic-frr/frr submodule to 8.2.2 commit id. Fixes issue #11484.

Co-authored-by: Hasan Naqvi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdosi abdosi

Labels
BRCM Issue for 202205 Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zhangyanzhao @yxieca @DavidZagury @liat-grozovik @abdosi