Skip to content

Commit

Permalink
[build]: Allow build-time specification of alternative docker registr…
Browse files Browse the repository at this point in the history
…ies (#8134)

Why I did it
Allows users to host their own local docker registries and utilize them via the REGISTRY_SERVER and REGISTRY_PORT environmental variables

How I did it
Only set REGISTRY_SERVER and REGISTRY_PORT in rules/config if they are unset.

How to verify it
Export environmental variables REGISTRY_SERVER and REGISTRY_PORT to an alternative docker registry. Export the environmental variable ENABLE_DOCKER_BASE_PULL to y.
Ensure the required sonic-slave docker images are not present locally, but are available in the docker registry
Execute make init and make configure
Confirm that the appropriate docker images were pulled from the appropriate docker registry, and not built locally
  • Loading branch information
jusherma authored and judyjoseph committed Aug 4, 2021
1 parent fee6a62 commit fd564b0
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions rules/config
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ SONIC_VERSION_CONTROL_COMPONENTS ?= none

# SONiC docker registry
#
# Uncomment below line to enable pulling sonic-slave docker from registry
# ENABLE_DOCKER_BASE_PULL = y
REGISTRY_PORT=443
REGISTRY_SERVER=sonicdev-microsoft.azurecr.io
# Set the env variable ENABLE_DOCKER_BASE_PULL = y to enable pulling sonic-slave docker from registry
REGISTRY_PORT ?= 443
REGISTRY_SERVER ?= sonicdev-microsoft.azurecr.io

0 comments on commit fd564b0

Please sign in to comment.