Recycle port HLD #742

ysmanman · 2021-01-26T01:39:20Z

No description provided.

eswaranb

Support host if for recycle port?
Update show command to support the recycle port.
Inband port can be configured to be Recirc0

eswaranb · 2021-01-27T17:36:39Z

doc/voq/recycle_port.md

+Ethernet8     56,57,58,59,60,61,62,63   Ethernet2/1  2      Ext        400000
+Ethernet16    64,65,66,67,68,69,70,71   Ethernet3/1  3      Ext        400000
+Ethernet24    72,73,74,75,76,77,78,79   Ethernet4/1  4      Ext        400000
+Recirc0       221                       Recirc0/0    5      Rec        400000


Inband0 221 Inband0 5 Rec 400000
Recirc0 222 Recirc0 6 Rec 400000

ysmanman · 2021-01-27T17:52:50Z

doc/voq/recycle_port.md

+Ethernet16    64,65,66,67,68,69,70,71   Ethernet3/1  3      Ext        400000
+Ethernet24    72,73,74,75,76,77,78,79   Ethernet4/1  4      Ext        400000
+Recirc0       221                       Recirc0/0    5      Rec        400000
+Recirc1       222                       Recirc0/1    6      Rec        400000


Add a new role Inb for inband.

ysmanman · 2021-01-27T17:53:17Z

doc/voq/recycle_port.md

+Ethernet8     56,57,58,59,60,61,62,63   Ethernet2/1  2      Ext        400000
+Ethernet16    64,65,66,67,68,69,70,71   Ethernet3/1  3      Ext        400000
+Ethernet24    72,73,74,75,76,77,78,79   Ethernet4/1  4      Ext        400000
+Recirc0       221                       Recirc0/0    5      Rec        400000


Rename Recirc0 -> Ethernet-Recirc0.

anshuv-mfst · 2021-02-03T17:22:01Z

@rlhui , @arlakshm - Could you please review the PR, thanks.
@skeesara-nokia - could you please review the PR, thanks.

Signed-off-by: vedganes <[email protected]> Based on review comments Recyle port HLD (sonic-net/SONiC#742) the inband port name prefix is changed from Inband to "Ethernet-IB" similar to what we have for Ethernet-BP (Ethernet-Backplane) in multi-asic design. Because of this changes, we no longer need "INBAND_PREFIX" definition since Ethernet-IB is covered in "INTFS_PREIFX"

Signed-off-by: vedganes <[email protected]> (1) Based on review comments Recyle port HLD (sonic-net/SONiC#742) the inband port name prefix is changed from Inband to "Ethernet-IB" similar to what we have for Ethernet-BP (Ethernet-Backplane) in multi-asic design. Changes are done in interface.py to handle this changed name (2) Code review comments fix for lldpmgrd

rlhui

How to create a recycle port with SAI?

ysmanman · 2021-03-03T17:21:27Z

How to create a recycle port with SAI?

This should be similar to front panel ports. Recycle ports are defined in port_config.ini, and are populated in APP_DB port table. portsorch retrieves ports list, including recycle ports, from SAI in initialization, and initialize recycle ports just like other front panel ports in doTask.

rlhui · 2021-03-03T18:38:27Z

How to create a recycle port with SAI?

This should be similar to front panel ports. Recycle ports are defined in port_config.ini, and are populated in APP_DB port table. portsorch retrieves ports list, including recycle ports, from SAI in initialization, and initialize recycle ports just like other front panel ports in doTask.

how to convey to ASIC SAI implementation that this is not an actual front-panel port, but to add 1 or 2 recycle ports?

ysmanman · 2021-03-03T18:55:20Z

How to create a recycle port with SAI?

This should be similar to front panel ports. Recycle ports are defined in port_config.ini, and are populated in APP_DB port table. portsorch retrieves ports list, including recycle ports, from SAI in initialization, and initialize recycle ports just like other front panel ports in doTask.

how to convey to ASIC SAI implementation that this is not an actual front-panel port, but to add 1 or 2 recycle ports?

If a SAI implementation needs to differentiate recycle port from recycle ports, it can encode a sub port type in the pid of recycle port. But this is transparent to orchagent since all orchagent needs is just a pid for recycle port.

abdosi · 2021-03-07T17:55:04Z

Some Question on QoS w.r.t Recycle Port:-

What about the Queue of recycle port ? Do we will have Queue stats for recycle port ? What will be behaviour of PFC and recycle port ? Can this port get back pressure for PFC queue 3 and 4 ?

abdosi

Some questions on Qos.

skeesara-nokia · 2021-02-24T17:34:22Z

doc/voq/recycle_port.md

+Ethernet16          64,65,66,67,68,69,70,71   Ethernet3/1  3      Ext        400000
+Ethernet24          72,73,74,75,76,77,78,79   Ethernet4/1  4      Ext        400000
+Ethernet-Rec0       221                       Recirc0/0    5      Rec        400000
+Ethernet-Rec1       222                       Recirc0/1    6      Inb        400000


The naming convention for inband ports is "Ethernet-IB0", "Ethernet-IB1" etc. Can you please change "Ethernet-Rec1" above to "Ethernet-IB0"

Sounds good. Fixed.

skeesara-nokia · 2021-03-09T15:24:31Z

Some Question on QoS w.r.t Recycle Port:-

What about the Queue of recycle port ? Do we will have Queue stats for recycle port ? What will be behaviour of PFC and recycle port ? Can this port get back pressure for PFC queue 3 and 4 ?

Recycle port is expected to have queue statistics like any other port.
The back pressure part may be implementation dependent. Expect more clarity on that once the Recycle port proposal is reviewed in the SAI forum.

skeesara-nokia · 2021-03-09T15:26:19Z

Some questions on Qos.

QOS for the recycle port in general works similar any other port. It will support queues, mappings, remarking etc.

rlhui · 2021-03-10T16:56:46Z

No description provided.

Some Question on QoS w.r.t Recycle Port:-
What about the Queue of recycle port ? Do we will have Queue stats for recycle port ? What will be behaviour of PFC and recycle port ? Can this port get back pressure for PFC queue 3 and 4 ?

Some Question on QoS w.r.t Recycle Port:-
What about the Queue of recycle port ? Do we will have Queue stats for recycle port ? What will be behaviour of PFC and recycle port ? Can this port get back pressure for PFC queue 3 and 4 ?

Recycle port is expected to have queue statistics like any other port.
The back pressure part may be implementation dependent. Expect more clarity on that once the Recycle port proposal is reviewed in the SAI forum.

I would like to request that we add to the doc the usage of the SAI recycle port API - the current raised idea is to add a subport type for the recycle port. How will this be used by the sonic applications/users?

rlhui · 2021-03-10T17:04:16Z

How to create a recycle port with SAI?

This should be similar to front panel ports. Recycle ports are defined in port_config.ini, and are populated in APP_DB port table. portsorch retrieves ports list, including recycle ports, from SAI in initialization, and initialize recycle ports just like other front panel ports in doTask.

how to convey to ASIC SAI implementation that this is not an actual front-panel port, but to add 1 or 2 recycle ports?

If a SAI implementation needs to differentiate recycle port from recycle ports, it can encode a sub port type in the pid of recycle port. But this is transparent to orchagent since all orchagent needs is just a pid for recycle port.

Would we please add to the doc on this. Thanks.

ysmanman · 2021-03-17T01:15:12Z

No description provided.

Some Question on QoS w.r.t Recycle Port:-
What about the Queue of recycle port ? Do we will have Queue stats for recycle port ? What will be behaviour of PFC and recycle port ? Can this port get back pressure for PFC queue 3 and 4 ?

Some Question on QoS w.r.t Recycle Port:-
What about the Queue of recycle port ? Do we will have Queue stats for recycle port ? What will be behaviour of PFC and recycle port ? Can this port get back pressure for PFC queue 3 and 4 ?

Recycle port is expected to have queue statistics like any other port.
The back pressure part may be implementation dependent. Expect more clarity on that once the Recycle port proposal is reviewed in the SAI forum.

I would like to request that we add to the doc the usage of the SAI recycle port API - the current raised idea is to add a subport type for the recycle port. How will this be used by the sonic applications/users?

The HLD proposes to use recycle port in a way that’s independent of the SAI recycele port API. In this proposal, SONiC application/users shouldn’t really care about if a subport type is defined for recycle port or not. What we proposed in the HLD is to use port role to identify recycle ports in SONiC and its applications. Detailedly, we define recycle ports by setting the specific port roles along with their lanes in port_config.ini. With lanes and roles from port_config.ini, portsorch should be able to initialize recycle ports and also uncover their pid returned by SAI. SONiC applications that need recycle ports, like Everflow, should simply request the pid of recycle port from portsorch. It’s not clear to me why we have to define a subport type for recycle port. Did I get your comment correct?

ysmanman · 2021-03-17T01:29:29Z

How to create a recycle port with SAI?

This should be similar to front panel ports. Recycle ports are defined in port_config.ini, and are populated in APP_DB port table. portsorch retrieves ports list, including recycle ports, from SAI in initialization, and initialize recycle ports just like other front panel ports in doTask.

how to convey to ASIC SAI implementation that this is not an actual front-panel port, but to add 1 or 2 recycle ports?

If a SAI implementation needs to differentiate recycle port from recycle ports, it can encode a sub port type in the pid of recycle port. But this is transparent to orchagent since all orchagent needs is just a pid for recycle port.

How to create a recycle port with SAI?

This should be similar to front panel ports. Recycle ports are defined in port_config.ini, and are populated in APP_DB port table. portsorch retrieves ports list, including recycle ports, from SAI in initialization, and initialize recycle ports just like other front panel ports in doTask.

how to convey to ASIC SAI implementation that this is not an actual front-panel port, but to add 1 or 2 recycle ports?

If a SAI implementation needs to differentiate recycle port from recycle ports, it can encode a sub port type in the pid of recycle port. But this is transparent to orchagent since all orchagent needs is just a pid for recycle port.

Would we please add to the doc on this. Thanks.

As I replied to another comment, this seems not relevant to the proposal in the HLD.

Signed-off-by: vedganes <[email protected]> Based on review comments Recyle port HLD (sonic-net/SONiC#742) the inband port name prefix is changed from Inband to "Ethernet-IB" similar to what we have for Ethernet-BP (Ethernet-Backplane) in multi-asic design. Because of this changes, we no longer need "INBAND_PREFIX" definition since Ethernet-IB is covered in "INTFS_PREIFX"

ysmanman · 2021-04-07T04:55:24Z

Some questions on Qos.

This comment had been addressed already. Copy the reply again to update review status:

QOS for the recycle port in general works similar any other port. It will support queues, mappings, remarking etc.

@ysmanman can we capture this point as part of document also.

Signed-off-by: vedganes <[email protected]> Based on review comments Recyle port HLD (sonic-net/SONiC#742) the inband port name prefix is changed from Inband to "Ethernet-IB" similar to what we have for Ethernet-BP (Ethernet-Backplane) in multi-asic design. Because of this changes, we no longer need "INBAND_PREFIX" definition since Ethernet-IB is covered in "INTFS_PREIFX"

ysmanman added 3 commits January 25, 2021 17:36

Add recycle port HLD.

2d2b88e

Update recycle port figure.

7c21045

Update example port_config.

321e417

ysmanman changed the title ~~Add recycle port HLD.~~ Recycle port HLD Jan 26, 2021

Fix date

018866a

eswaranb reviewed Jan 27, 2021

View reviewed changes

ysmanman commented Jan 27, 2021

View reviewed changes

ysmanman added 4 commits January 27, 2021 10:26

Address comments in HLD review.

dade687

Update reccyle port name.

a6d312c

Update HLD.

8694771

Update HLD.

a88e875

anshuv-mfst requested review from rlhui and arlakshm February 3, 2021 17:22

rlhui reviewed Mar 3, 2021

View reviewed changes

abdosi requested changes Mar 7, 2021

View reviewed changes

skeesara-nokia reviewed Mar 9, 2021

View reviewed changes

Rename inband port Ethernet-Rec1 to Ethernet-IB0.

eaffd39

skeesara-nokia approved these changes Mar 9, 2021

View reviewed changes

ysmanman requested a review from abdosi April 7, 2021 04:50

ysmanman added 4 commits May 5, 2021 16:49

Address review comments

ad646bc

Fix typo

8f8f353

Add a seciont for SAI

ed56385

Add config example in platform.json

1066f94

abdosi approved these changes May 19, 2021

View reviewed changes

abdosi merged commit 7d27ce8 into sonic-net:master Jun 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recycle port HLD #742

Recycle port HLD #742

ysmanman commented Jan 26, 2021

eswaranb left a comment

eswaranb Jan 27, 2021

ysmanman Jan 27, 2021

ysmanman Jan 27, 2021

anshuv-mfst commented Feb 3, 2021

rlhui left a comment

ysmanman commented Mar 3, 2021

rlhui commented Mar 3, 2021

ysmanman commented Mar 3, 2021

abdosi commented Mar 7, 2021

abdosi left a comment

skeesara-nokia Feb 24, 2021

ysmanman Mar 9, 2021

skeesara-nokia commented Mar 9, 2021

skeesara-nokia commented Mar 9, 2021

rlhui commented Mar 10, 2021

rlhui commented Mar 10, 2021

ysmanman commented Mar 17, 2021

ysmanman commented Mar 17, 2021

ysmanman commented Apr 7, 2021 •

edited by abdosi

Loading

Recycle port HLD #742

Recycle port HLD #742

Conversation

ysmanman commented Jan 26, 2021

eswaranb left a comment

Choose a reason for hiding this comment

eswaranb Jan 27, 2021

Choose a reason for hiding this comment

ysmanman Jan 27, 2021

Choose a reason for hiding this comment

ysmanman Jan 27, 2021

Choose a reason for hiding this comment

anshuv-mfst commented Feb 3, 2021

rlhui left a comment

Choose a reason for hiding this comment

ysmanman commented Mar 3, 2021

rlhui commented Mar 3, 2021

ysmanman commented Mar 3, 2021

abdosi commented Mar 7, 2021

abdosi left a comment

Choose a reason for hiding this comment

skeesara-nokia Feb 24, 2021

Choose a reason for hiding this comment

ysmanman Mar 9, 2021

Choose a reason for hiding this comment

skeesara-nokia commented Mar 9, 2021

skeesara-nokia commented Mar 9, 2021

rlhui commented Mar 10, 2021

rlhui commented Mar 10, 2021

ysmanman commented Mar 17, 2021

ysmanman commented Mar 17, 2021

ysmanman commented Apr 7, 2021 • edited by abdosi Loading

ysmanman commented Apr 7, 2021 •

edited by abdosi

Loading