Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next hop group split HLD #712

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Next hop group split HLD #712

merged 2 commits into from
Oct 18, 2021

Conversation

TACappleman
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Nov 25, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@TACappleman
Copy link
Contributor Author

We believe that all comments on this have been sufficiently dealt with, so will seek to close the request in a week. @qiluo-msft please let me know before then if this is not the case.

@TACappleman
Copy link
Contributor Author

@qiluo-msft Are there any further issues that need resolving on this or can the comments be resolved and the design merged in?

@TACappleman
Copy link
Contributor Author

Can this now be merged?

TACappleman added a commit to TACappleman/sonic-mgmt that referenced this pull request May 11, 2021
@TACappleman
Test plan for next hop split
359f298 
What is the motivation for this PR?
This is the test plan for the next hop group split enhancement, as covered in PR 712 (sonic-net/SONiC#712)
@TACappleman TACappleman mentioned this pull request May 11, 2021
Merged
2 tasks
prsunny
prsunny approved these changes Aug 7, 2021
View reviewed changes
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, wait for other reviewers

@TACappleman TACappleman requested a review from qiluo-msft August 31, 2021 08:59
wangxin pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Oct 9, 2021
@TACappleman
Test plan for next hop split (#3459)
0bf0a8e 
What is the motivation for this PR?
This is the test plan for the next hop group split enhancement, as covered in PR 712 (sonic-net/SONiC#712)
@TACappleman TACappleman merged commit 170295e into sonic-net:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkatmahalingam venkatmahalingam venkatmahalingam left review comments

@nkelapur nkelapur nkelapur left review comments

@prsunny prsunny prsunny approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TACappleman @qiluo-msft @prsunny @nkelapur @venkatmahalingam