Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Update psud design to a separate document and add PSU led enhancement #591

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

Junchao-Mellanox
Copy link
Contributor

When I write this document, SONiC already has a PSU daemon called psud running in pmon docker. There is already a high level design document which contains existing psud design, but some of its content is out of date. This document will update the design of current PSU daemon implementation and add an enhancement about PSU led management.

doc/psud/PSU_daemon_design.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove from the older design the PSU part if not relevant and poin tot the new HLD currenty avaialbe. this will reduce any mistakes on what is avaialble and from where to look for the details.

@liat-grozovik
Copy link
Collaborator

@jleveque any additional feedback? this HLD was already implemented and code is already available.
from my POV we should merge as it should align to the current implementation to who ever want to check

@jleveque jleveque merged commit 7f72f59 into sonic-net:master Sep 23, 2020
@Junchao-Mellanox Junchao-Mellanox deleted the psud branch September 23, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants