Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading/writing module EEPROM by page and offset #1475

Merged
merged 10 commits into from
Dec 10, 2023
Merged

Support reading/writing module EEPROM by page and offset #1475

merged 10 commits into from
Dec 10, 2023

Conversation

Junchao-Mellanox
Copy link
Contributor

@Junchao-Mellanox Junchao-Mellanox commented Sep 18, 2023 •
edited
Loading

Overview

CLI sfputil shall be extended to support reading/writing cable EEPROM by page and offset. This implementation is based on existing platform API sfp.read_eeprom and sfp.write_eeprom.

PR

PR title state context
[sonic-utilities] Support reading/writing module EEPROM data by page and offset GitHub issue/pull request detail GitHub pull request check contexts

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft September 19, 2023 02:54
prgeor
prgeor reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@prgeor prgeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Junchao-Mellanox PR still in draft?

@Junchao-Mellanox
Copy link
Contributor Author

@Junchao-Mellanox PR still in draft?

Hi @prgeor , it is mostly done, won't have major change.

@prgeor
Copy link
Contributor

prgeor commented Oct 5, 2023

@Junchao-Mellanox PR still in draft?

Hi @prgeor , it is mostly done, won't have major change.

@Junchao-Mellanox if no more change, please remove draft?

@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review October 7, 2023 02:46
This was referenced Oct 10, 2023
Closed
Merged
@prgeor prgeor requested a review from mihirpat1 October 12, 2023 05:52
mihirpat1
mihirpat1 reviewed Oct 18, 2023
View reviewed changes
doc/sfputil/read_write_eeprom_by_page.md Outdated Show resolved Hide resolved
doc/sfputil/read_write_eeprom_by_page.md Outdated Show resolved Hide resolved
@Junchao-Mellanox
Copy link
Contributor Author

Hi @mihirpat1 , I fixed all comments, could you please review again?

mihirpat1
mihirpat1 previously approved these changes Oct 19, 2023
View reviewed changes
@Junchao-Mellanox
Copy link
Contributor Author

Hi @mihirpat1 , could you please help approve again? I just made a very minor change.

liat-grozovik
liat-grozovik previously approved these changes Oct 23, 2023
View reviewed changes
mihirpat1
mihirpat1 previously approved these changes Oct 23, 2023
View reviewed changes
@liat-grozovik
Copy link
Collaborator

@Junchao-Mellanox thanks for handling PR comments. @prgeor can you please review if all good approve so we can merge?

@Junchao-Mellanox Junchao-Mellanox mentioned this pull request Dec 8, 2023
Merged
@liat-grozovik liat-grozovik merged commit 1c87ec4 into sonic-net:master Dec 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snider-nokia snider-nokia snider-nokia left review comments

@prgeor prgeor prgeor approved these changes

@keboliu keboliu keboliu approved these changes

@mihirpat1 mihirpat1 mihirpat1 left review comments

@liat-grozovik liat-grozovik liat-grozovik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Junchao-Mellanox @prgeor @liat-grozovik @keboliu @snider-nokia @mihirpat1