Combine v4 and v6 L3 ACL rules on optimized platforms #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rck-innovium
force-pushed
the
marvell_l3_acl
branch
from
6a7a0d0 to
b94b023
Compare
|
reviewed in community meeting. |
bingwang-ms
reviewed
Feb 21, 2023
bingwang-ms
reviewed
Feb 21, 2023
|
The proposal looks god to me. Actually, I was doing similar investigation as well. I tried to implement same feature with the custom ACL type introduced by this PR sonic-net/sonic-swss#1982. We may define the new ACL table type by configuration without code change, |
|
@zhangyanzhao Please add me as the reviewer. |
|
community review recording https://zoom.us/rec/share/4-yYo-RXcFAKMxptEFExMMFYYGJnHfizv9G9I3ySVzdAfg-JN21vJdg5MOTR4HKz.OqXPjTeeWNi64ocW |
Please look at the updated proposal. This needs ACL orchagent changes. |
rck-innovium
requested review from
venkatmahalingam,
svshah-intel and
bingwang-ms
rck-innovium
changed the title
bingwang-ms
reviewed
Apr 3, 2023
bingwang-ms
reviewed
Apr 3, 2023
bingwang-ms
reviewed
Apr 3, 2023
bingwang-ms
reviewed
Apr 3, 2023
rck-innovium
added a commit
to rck-innovium/sonic-swss
that referenced
this pull request
Apr 14, 2023
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
rck-innovium
added a commit
to rck-innovium/sonic-mgmt-common
that referenced
this pull request
Apr 14, 2023
This table supports both v4 and v6 Match types. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
rck-innovium
added a commit
to rck-innovium/sonic-mgmt-common
that referenced
this pull request
Apr 14, 2023
This table supports both v4 and v6 Match types. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
rck-innovium
added a commit
to rck-innovium/sonic-utilities
that referenced
this pull request
Apr 16, 2023
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
bingwang-ms
previously approved these changes
Apr 18, 2023
rck-innovium
added a commit
to rck-innovium/sonic-buildimage
that referenced
this pull request
Apr 22, 2023
This table supports both v4 and v6 Match types. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
1 task
rck-innovium
added a commit
to rck-innovium/sonic-swss
that referenced
this pull request
Apr 22, 2023
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
rck-innovium
requested review from
svshah-intel
and removed request for
svshah-intel
rules in L3V6 ACL tables on platforms optimized for this.
Ether-type and IP type is not enforced in SWSS. The underlying SAI platform handles the case when both of these fields are not provided.
rck-innovium
force-pushed
the
marvell_l3_acl
branch
from
aac0039 to
f744bab
Compare
svshah-intel
approved these changes
May 1, 2023
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
May 1, 2023
This table supports both v4 and v6 Match types. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected] Signed-off-by: Ravi(Marvell) [email protected]
bingwang-ms
approved these changes
May 5, 2023
rck-innovium
added a commit
to rck-innovium/sonic-utilities
that referenced
this pull request
May 9, 2023
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
rck-innovium
added a commit
to rck-innovium/sonic-utilities
that referenced
this pull request
May 10, 2023
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267 Signed-off-by: Ravi(Marvell) [email protected]
prsunny
reviewed
May 12, 2023
prsunny
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 5, 2023
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
Support a new ACL table type called L3V4V6. This table supports both v4 and v6 Match types. Add unit tests for this new ACL table type. HLD: sonic-net/SONiC#1267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document describes the SONiC ACL optimization for using IPv4 ACL rules in L3V6 ACL tables on platforms optimized for this.