Add an internal config table to apply unexposed configurations to switch before testing #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyzhai
reviewed
Nov 5, 2024
dash-pipeline/SAI/src/dashsai.cpp
Outdated
| } | ||
|
|
||
| printf("Inserted entry into internal_config table successfully"); | ||
|
|
||
| return SAI_STATUS_SUCCESS; |
There was a problem hiding this comment.
Better to add individual test fixture to update internal_config, instead of in apiInitialize
There was a problem hiding this comment.
Removing this part from this PR to become another PR.
ShaofengWu123
changed the title
jimmyzhai
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renamed the table
underlay_mactointernal_config. The newinternal_configtable is ignored for SAI API generation and will be used for setting switch to a initial state required by some test cases.For example, setting
flow_enabledtoFalsewill cause packet to bypass the flow table in the pipeline. In order to test dash flow, we can setflow_enabledtoTruebefore corresponding tests, e.g. ptf testsaidashflow.py.