Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency for protected_attributes #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dferrazm
Copy link

Remove the dependency for protected_attributes in order to make it Rails 5 compliant.

Copy link

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, except that I am already upgraded to rails 5.2
so why wasn't this necessary?

@dferrazm
Copy link
Author

Hey. I'm not sure. Good question. It's been some time since I created this PR. But even if it's already on Rails 5.2, would be good to try to remove this dependency anyway.

Feel free to accept it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants