Remove attr_accessible for Rails 4 compatibility.
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this with Rails 4 raises an error on `attr_accessible` as it is removed, in favour of `strong_params`. The onus is now on the implementer to only permit `name` and `redirect_uri` when creating an authorization.
|
This fixes the issue for me as well. Thanks! |
|
We did work to make this work on ActiveRecord 4.0 a while ago, and the build is passing. Do you have a test case that fails? |
|
You can demonstrate the problem by spinning up a bare rails app with a single model and including the ResourceOwner module. You can see this gist for a complete recreation script: https://gist.github.com/danielevans/7107532 |
|
FYI: The exact error given is .rvm/gems/ruby-1.9.3-p448@auth/gems/activemodel-4.0.0/lib/active_model/deprecated_mass_assignment_security.rb:17:in `attr_accessible': `attr_accessible` is extracted out of Rails into a gem. Please use new recommended protection model for params(strong_parameters) or add `protected_attributes` to your Gemfile to use old one. (RuntimeError)
from /Users/xxxxx/.rvm/gems/ruby-1.9.3-p448@xxxxx/gems/songkick-oauth2-provider-0.10.2/lib/songkick/oauth2/model/client.rb:18:in `<class:Client>' |
|
+1 |
|
Any reason this isn't merged yet? I can also confirm it's an issue with Rails 4. |
|
Any update? |
|
I have the same problem, any update? |
|
+1 |
|
+1. Any updates? |
|
+1 |
|
👍 any ETA as to when this will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this with Rails 4 raises an error on
attr_accessibleas it isremoved, in favour of
strong_params.The onus is now on the implementer to only permit
nameandredirect_uriwhen creating an authorization.