Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect file name regex logic #21

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Fix incorrect file name regex logic #21

merged 5 commits into from
Nov 30, 2021

Commits on Oct 10, 2021

  1. Create failing test code. 

    - `getDebugFileName` only checks whether '.js' is in the file name. So the 'john.jspiner' case throws an error.
    @JSpiner
    JSpiner authored and smith.jspiner committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    c8bc216 View commit details
    Browse the repository at this point in the history

  2. Fix getDebugFileName file regex logic. 

    - The file extension must be at the end of the full path.
    @JSpiner
    JSpiner authored and smith.jspiner committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    790d4f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. Use $ regex character instead of check is ends with file extension. 

    - Thanks to @ataylor284
    @JSpiner
    JSpiner authored and smith.jspiner committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    9eb5223 View commit details
    Browse the repository at this point in the history

  2. Change getDebugFileName to protected function for testing. 

    - Remove reflection test.
- Thanks to @ataylor284
    @JSpiner
    JSpiner authored and smith.jspiner committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    68d3969 View commit details
    Browse the repository at this point in the history

  3. Add license header to file. 

    - And reformat code.
- Thanks to @dbradicich
    @JSpiner
    JSpiner authored and smith.jspiner committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    d7a1d5c View commit details
    Browse the repository at this point in the history