This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
fix: remove last pathway that gzips content en route to bucket #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to latest version of google-cloud-storage which makes this possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #53, we found that disabling gzip compression unlocked some significant throughput gains. That change set left one remaining pathway where gzip compression would be performed by the
google-cloud-storagedependency on blob content en route to the storage bucket.The latest version of the
google-cloud-storagedependency includes googleapis/java-storage@65d3739, which allows us to turn off GZIP compression on that remaining pathway.This pull request pulls in that new library version and makes the last change needed.
The result is a 200% increase in throughput (47.7 requests/sec compared to 23.5 in #53):
Stackdriver Profiler confirms the reduction in CPU utilization, dropping the CPU time spent on handling client requests to/from the bucket from 18.5% down to 1.1%:
Fixes #56 .