Stable v0.1 - move from CoreBundle

[wbloszyk]

Subject

This RP migrate Form from CoreBundle upgraded in sonata-project/SonataCoreBundle#741 process.

I am targeting this branch, because 0.x have not stable release yet.

Part of sonata-project/dev-kit#697

[wbloszyk]

@contributors Anyone can help? Travis fails but tests pass.

It is not RTM yet.

[VincentLanglet]

@contributors Anyone can help? Travis fails but tests pass.

You added tests which did not perform any assertions. You have to fix this.

1) Sonata\Form\Tests\Type\BasePickerTypeTest::testConstructorLegacy
This test did not perform any assertions
/home/travis/build/sonata-project/form-extensions/tests/Type/BasePickerTypeTest.php:103
2) Sonata\Form\Tests\Type\BooleanTypeTest::testBuildForm
This test did not perform any assertions
/home/travis/build/sonata-project/form-extensions/tests/Type/BooleanTypeTest.php:27
3) Sonata\Form\Tests\Type\CollectionTypeTest::testBuildForm
This test did not perform any assertions
/home/travis/build/sonata-project/form-extensions/tests/Type/CollectionTypeTest.php:24
4) Sonata\Form\Tests\Type\DatePickerTypeTest::testBuildForm
This test did not perform any assertions
/home/travis/build/sonata-project/form-extensions/tests/Type/DatePickerTypeTest.php:29
5) Sonata\Form\Tests\Type\DateTimePickerTypeTest::testBuildForm
This test did not perform any assertions
/home/travis/build/sonata-project/form-extensions/tests/Type/DateTimePickerTypeTest.php:29
6) Sonata\Form\Tests\Type\EqualTypeTest::testBuildForm
This test did not perform any assertions
/home/travis/build/sonata-project/form-extensions/tests/Type/EqualTypeTest.php:26
7) Sonata\Form\Tests\Type\ImmutableArrayTypeTest::testBuildForm
This test did not perform any assertions
/home/travis/build/sonata-project/form-extensions/tests/Type/ImmutableArrayTypeTest.php:29

[wbloszyk]

I think this should be ignore. This tests is working in specifical configuration. I will fix it in Monday.

[VincentLanglet]

I think this should be ignore. This tests is working in specifical configuration. I will fix it in Monday.

There is something like a DoesNotPerformAssertion annotation.

But I think, the report is interesting. When a testBuildForm report no assertion and the test contains

$formBuilder
            ->expects($this->any())
            ->method('add')
            ->willReturnCallback(function ($name, $type = null) {
                if (null !== $type) {
                    $this->assertTrue(class_exists($type), sprintf('Unable to ensure %s is a FQCN', $type));
                }
            });

This would mean that this code is useless.

[greg0ire]

Yup, @doesNotPerformAssertions should do the trick.

[wbloszyk]

I will revert this in Monday.

[greg0ire]

Thanks @wbloszyk !