Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for array and traversable #343

Merged
merged 2 commits into from
Jul 12, 2020
Merged

Add support for array and traversable #343

merged 2 commits into from
Jul 12, 2020

Conversation

VincentLanglet
Copy link
Member

Subject

I am targeting this branch, because BC.

Closes #31.

Changelog

### Added
- Added support for array and traversable in `DoctrineORMQuerySourceIterator`, `DoctrineODMQuerySourceIterator` and `PropelCollectionSourceIterator`.

@VincentLanglet VincentLanglet requested a review from a team July 10, 2020 14:54
@phansys phansys added the minor label Jul 10, 2020
@VincentLanglet VincentLanglet requested a review from a team July 10, 2020 15:33
phansys
phansys previously approved these changes Jul 10, 2020
View reviewed changes
@VincentLanglet VincentLanglet requested a review from a team July 10, 2020 21:55
@VincentLanglet
Copy link
Member Author

Phpdoc is updated @greg0ire :)

@VincentLanglet VincentLanglet requested review from a team and removed request for a team July 12, 2020 11:37
@VincentLanglet VincentLanglet merged commit 00c96b0 into sonata-project:2.x Jul 12, 2020
@VincentLanglet VincentLanglet deleted the arrayField branch July 12, 2020 11:38
@ossinkine ossinkine mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@phansys phansys phansys left review comments

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle type array in the DoctrineORMQuerySourceIterator
3 participants
@VincentLanglet @greg0ire @phansys