remove scrutinizer due it's deprecation by it's authors #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
approved these changes
Aug 23, 2020
greg0ire
approved these changes
Aug 23, 2020
|
We also need to remove the we hook by the command. It needs some manual work, I can do that Please wait before merging this PR |
core23
approved these changes
Aug 23, 2020
I am removing the hook in #836 |
|
All hooks are removed, so lets merge this one 👍 Thank you @vladyslavstartsev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During implementation of sonata-project/SonataAdminBundle#6288 I've found out that I broke
scrutinizer-ci. When investigating the reason why I've found that, internally it (the scrutinizer-ci) uses outdated version ofcomposer-plugin-api(the error is similar to composer/composer#2324).There are a list of reasons for removing it, see it here sonata-project/SonataAdminBundle#6288 (comment)
This PR only removes it (the scrutinizer-ci) for new repositories