Created SeoAwareTrait #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| trait SeoAwareTrait | ||
| { | ||
| /** | ||
| * @var SeoPageInterface|null |
There was a problem hiding this comment.
What about adding @required it will try to autowire it.
There was a problem hiding this comment.
Didn't find any examples in the other traits.
Should you use autowiring when there is a setter method?
There was a problem hiding this comment.
why not? You can still set it yourself or let it be autowired. A better question is, should we autowire it at all, I think it is not a best practice for 3rd party bundles.
|
Do we need to tweak the docs or add a cookbook article about it? |
|
Yes, people need to know about it so they can use it. |
3 tasks
kunicmarko20
approved these changes
Jun 16, 2018
OskarStark
approved these changes
Jun 18, 2018
|
Thanks @core23 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this is a new feature.
Changelog
Subject
This trait can be used the same way as the
LoggerAwareTrait,ContainerAwareTrait, ...