Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add constraint for host field fix #491 #728

Merged
merged 1 commit into from
Oct 4, 2016
Merged

add constraint for host field fix #491 #728

merged 1 commit into from
Oct 4, 2016
+3 −0

Conversation

symfou
Copy link
Contributor

@symfou symfou commented Oct 2, 2016 •
edited by OskarStark
Loading

I am targetting this branch, because it's a patch.

Fixes #491

Changelog

### Fixed
 - Failed to create object: AppBundle\Entity\Site

Subject

Add necessary constraint

core23
core23 approved these changes Oct 2, 2016
View reviewed changes
Copy link
Member

@core23 core23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@core23
Copy link
Member

core23 commented Oct 2, 2016

Please squash your commits

@greg0ire greg0ire merged commit 1b8c129 into sonata-project:3.x Oct 4, 2016
@qsomazzi
Copy link
Member

qsomazzi commented Oct 19, 2016 •
edited
Loading

Hello @sonata-project/contributors.
I think there was a mistake here, the constraint is set on Page entity, or the property host is on Site.

This result in a 500 page while trying to edit a page :
Property "host" does not exist in class "Sonata\PageBundle\Model\Page" 500 Internal Server Error - ValidatorException

Can we revert this and make another pr to move the code added ?

PS : on the first PR, the code was at the right place (https://github.com/sonata-project/SonataPageBundle/pull/491/files)

@greg0ire
Copy link
Contributor

Can we revert this and make another pr to move the code added ?

Can you make a PR that moves the constraint to the right entity? It will be easier to understand IMO

@OskarStark
Copy link
Member

I will provide a PR, give me a second

OskarStark added a commit to OskarStark/SonataPageBundle that referenced this pull request Oct 19, 2016
@OskarStark
Revert "add constraint for host field fix (sonata-project#728)"
ef177b1 
This reverts commit 1b8c129.
@OskarStark OskarStark mentioned this pull request Oct 19, 2016
Merged
@OskarStark
Copy link
Member

I created the PR here: #736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@symfou @core23 @qsomazzi @greg0ire @OskarStark @SonataCI