Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Sonata admin translation #1627

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Remove Sonata admin translation #1627

merged 2 commits into from
Oct 6, 2022

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Oct 4, 2022 •
edited
Loading

Remove SonataAdmin translation files and fixed snapshot translation.

I am targeting this branch, because It wasn't correct in 4.x branch.

Changelog

### Removed
- Removed SonataAdmin translation files

### Fixed
- Fixed `snapshot` translation

@eerison eerison force-pushed the remove-sonata_admin_translation branch from e536a53 to a46d1cc Compare October 4, 2022 08:45
@eerison eerison marked this pull request as ready for review October 4, 2022 08:49
@eerison
Copy link
Contributor Author

eerison commented Oct 4, 2022

@VincentLanglet could you review , please!

@jordisala1991 jordisala1991 merged commit 828e020 into sonata-project:4.x Oct 6, 2022
@eerison eerison deleted the remove-sonata_admin_translation branch October 6, 2022 06:50
@eerison eerison mentioned this pull request Oct 6, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eerison @jordisala1991 @VincentLanglet